Nick Piggin <npiggin@suse.de> wrote:

quoted text
> PAGE_CACHE_SIZE should be used to address the pagecache.

Perhaps, but the function being called from there takes pages not page cache
slots.  If I have to allow for PAGE_CACHE_SIZE > PAGE_SIZE then I need to
modify my code, if not then the assertion needs to remain what it is.

quoted text
> > I notice you removed the stuff that clears holes in the page to be
> > written.  Is this is now done by the caller?
> 
> It is supposed to bring the page uptodate first. So, no need to clear
> AFAIKS?

Hmmm...  I suppose.  However, it is wasteful in the common case as it is then
bringing the page up to date by filling/clearing the whole of it and not just
the bits that are not going to be written.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html