Re: [PATCH 09/31] IGET: Stop BFS from using iget() and read_inode() [try #3]

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Roel Kluin <12o3l@...>
Cc: <dhowells@...>, <hch@...>, <viro@...>, <torvalds@...>, <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>
Date: Thursday, October 11, 2007 - 3:39 am

Roel Kluin <12o3l@tiscali.nl> wrote:


In the first case, no because an OOM error was returned rather than an inode,
and in the second case, no because an extant non-locked inode was returned.

The inode is only returned locked by iget_locked() if it is also new - in
which case we don't return in either of the above two statements.


Take a look at what iget_failed() does (patch #3):

	void iget_failed(struct inode *inode)
	{
		make_bad_inode(inode);
		unlock_new_inode(inode);
		iput(inode);
	}

David
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/31] Remove iget() and read_inode() [try #3], David Howells, (Wed Oct 10, 5:43 pm)
Re: [PATCH 09/31] IGET: Stop BFS from using iget() and read_..., David Howells, (Thu Oct 11, 3:39 am)
[PATCH 05/31] IGET: Use iget_failed() in GFS2 [try #3], David Howells, (Wed Oct 10, 5:43 pm)
[PATCH 04/31] IGET: Use iget_failed() in AFS [try #3], David Howells, (Wed Oct 10, 5:43 pm)