On Wed, Dec 06, 2006 at 07:46:50PM +0100, Jan Engelhardt wrote:
quoted text
> I smell a big conspiracy! So yet again it's mixed mixed
>=20
> fs$ grep __init */*.c | grep -v ' init_'
> sysfs/mount.c:int __init sysfs_init(void)
> sysv/inode.c:int __init sysv_init_icache(void)
> proc/vmcore.c:static int __init vmcore_init(void)
> proc/nommu.c:static int __init proc_nommu_init(void)
> proc/proc_misc.c:void __init proc_misc_init(void)
> proc/proc_tty.c:void __init proc_tty_init(void)
> proc/root.c:void __init proc_root_init(void)
=20
Yep.
=20
quoted text
> >> > >+void __unionfs_mknod(void *data)
> >> > >+{
> >> > >+	struct sioq_args *args =3D data;
> >> > >+	struct mknod_args *m =3D &args->mknod;
> >> >=20
> >> > Care to make that: const struct mknod_args *m =3D &args->mknod;?
> >> > (Same for other places)
> >> =20
> >> Right.
> >=20
> >If I make the *args =3D data line const, then gcc (4.1) yells about =
modifying
quoted text
> >a const variable 3 lines down..
> >
> >args->err =3D vfs_mknod(m->parent, m->dentry, m->mode, m->dev);
> >
> >Sure, I could cast, but that seems like adding cruft for no good rea=
son.
quoted text
>=20
> No I despise casts more than missing consts. Why would gcc throw a wa=
rning?
quoted text
> Let's take this super simple program

No, this program doesn't tickle the problem.. Try to compile this one:

<<<
struct mknod_args {
	int mode;
	int dev;
};

void  __mknod(const void *data)
{
	const struct mknod_args *args =3D data;
	args->mode =3D 0;
}

int main(void) {
	const struct mknod_args *m;
	__mknod(m);
	return 0;
}
quoted text
>>>

$ gcc -Wall -c test.c
test.c: In function =E2mknod=E2test.c:10: error: assignment of read-onl=
y location


Josef "Jeff" Sipek.

--=20
Reality is merely an illusion, albeit a very persistent one.
		- Albert Einstein