Home » Mailing list archives » linux-ext4 » 2010 » June » 1

[PATCH 2.6.33.y 31/40] ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Theodore Ts'o
Subject: [PATCH 2.6.33.y 31/40] ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate
Date: Tuesday, June 1, 2010 - 5:03 am

From: Nikanth Karthikesan <knikanth@suse.de>

commit 6d19c42b7cf81c39632b6d4dbc514e8449bcd346 upstream (as of v2.6.34-git13)

Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit
and create a file larger than the limit. Add a check for that.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Signed-off-by: Amit Arora <aarora@in.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/extents.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 39aab5c..2ff79e8 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3601,6 +3601,11 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)
 	 */
 	credits = ext4_chunk_trans_blocks(inode, max_blocks);
 	mutex_lock(&inode->i_mutex);
+	ret = inode_newsize_ok(inode, (len + offset));
+	if (ret) {
+		mutex_unlock(&inode->i_mutex);
+		return ret;
+	}
 retry:
 	while (ret >= 0 && ret < max_blocks) {
 		block = block + ret;
-- 
1.6.6.1.1.g974db.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 2.6.33.y 01/40] ext4: Use bitops to read/modify EXT ..., Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 02/40] ext4: Fix BUG_ON at fs/buffer.c:652 ..., Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 03/40] ext4: Add flag to files with blocks ..., Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 05/40] ext4: fix error handling in migrate, Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 09/40] ext4: Fix insertion point of extent ..., Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 10/40] ext4: Fix the NULL reference in dou ..., Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 11/40] ext4: Code cleanup for EXT4_IOC_MOV ..., Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 12/40] ext4: Fix estimate of # of blocks n ..., Theodore Ts'o, (Tue Jun 1, 5:02 am)
[PATCH 2.6.33.y 13/40] ext4: Fixed inode allocator to corr ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 14/40] ext4: Fix possible lost inode write ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 15/40] ext4: Fix buffer head leaks after c ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 16/40] ext4: Issue the discard operation * ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 17/40] ext4: check missed return value in ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 18/40] ext4: fix memory leaks in error pat ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 19/40] ext4: Remove unnecessary call to ex ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 20/40] ext4: rename ext4_mb_release_desc() ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 21/40] ext4: allow defrag (EXT4_IOC_MOVE_E ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 22/40] ext4: fix quota accounting in case ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 23/40] ext4: check s_log_groups_per_flex i ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 24/40] ext4: don't return to userspace aft ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 25/40] ext4: stop issuing discards if not ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 26/40] ext4: don't scan/accumulate more pa ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 27/40] ext4: Do not zero out uninitialized ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 28/40] ext4: clean up inode bitmaps manipu ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 29/40] ext4: init statistics after journal ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 30/40] ext4: Remove extraneous newlines in ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 31/40] ext4: Prevent creation of files lar ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 32/40] ext4: check for a good block group ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 34/40] ext4: Use bitops to read/modify i_f ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 39/40] ext4: Fix compat EXT4_IOC_ADD_GROUP, Theodore Ts'o, (Tue Jun 1, 5:03 am)
[PATCH 2.6.33.y 40/40] ext4: Make fsync sync new parent di ..., Theodore Ts'o, (Tue Jun 1, 5:03 am)
Re: [stable] [PATCH 2.6.33.y 01/40] ext4: Use bitops to re ..., Greg KH, (Wed Jul 28, 4:29 pm)