| From | Subject | Date |
|---|---|---|
| Anshuman Aggarwal | ext4 fs recovery
Hi all,
I have an ext4 partition which is unable to find its superblock on e2fsck.
#e2fsck -n /dev/VGdata/LVstore
e2fsck 1.41.11 (14-Mar-2010)
e2fsck: Superblock invalid, trying backup blocks...
e2fsck: Bad magic number in super-block while trying to open /dev/VGdata/LVstore
The superblock could not be read or does not describe a correct ext2
filesystem. If the device is valid and it really contains an ext2
filesystem (and not swap or ufs or something else), then the superblock
is ...
| Apr 9, 4:02 pm 2010 |
| Dmitry Monakhov | [PATCH] ext4: Do not zeroout uninitialized extents beyon ...
Zerrout trick allow us to optimize cases where it is more reasonable
to explicitly zeroout extent and mark it as initialized instead of
splitting to several small ones.
But this optimization is not acceptable is extent is beyond i_size
Because it is not possible to have initialized blocks after i_size.
Fsck treat this as incorrect inode size.
BUG# 15742
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext4/extents.c | 49 ++++++++++++++++++++++++++++++++++++++-----------
1 ...
| Apr 9, 10:22 am 2010 |
| bugzilla-daemon | [Bug 15742] New: Fallocated extents handled incorrectly ...
https://bugzilla.kernel.org/show_bug.cgi?id=15742
Summary: Fallocated extents handled incorrectly if beyond
i_size
Product: File System
Version: 2.5
Kernel Version: v2.6.25
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: ext4
AssignedTo: fs_ext4@kernel-bugs.osdl.org
ReportedBy: ...
| Apr 9, 10:21 am 2010 |
| bugzilla-daemon | [Bug 15742] Fallocated extents handled incorrectly if be ...
https://bugzilla.kernel.org/show_bug.cgi?id=15742
--- Comment #2 from Dmitry Monakhov <dmonakhov@openvz.org> 2010-04-09 17:24:00 ---
Proposed patch:
http://patchwork.ozlabs.org/patch/49856/
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
| Apr 9, 10:24 am 2010 |
| Dmitry Monakhov | [PATCH] ext4: Do not zeroout uninitialized extents beyon ...
Zerrout trick allow us to optimize cases where it is more reasonable
to explicitly zeroout extent and mark it as initialized instead of
splitting to several small ones.
But this optimization is not acceptable is extent is beyond i_size
Because it is not possible to have initialized blocks after i_size.
Fsck treat this as incorrect inode size.
#BUG# (here suppose to be bug number, but bugzilla.kernel.org is too
dammit slow)
##TESTCASE
/***********************************************
...
| Apr 9, 10:14 am 2010 |
| Dmitry Monakhov | Apr 9, 10:18 am 2010 | |
| Andi Kleen | Re: ext4 dbench performance with CONFIG_PREEMPT_RT
FWIW we've been also seeing this on larger systems without RT.
The journal locks are the number one contention in some workloads.
So it's not just a RT problem.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
| Apr 9, 8:49 am 2010 |
| tytso | Re: ext4 dbench performance with CONFIG_PREEMPT_RT
Yeah, I'm very much aware of that. What worries me is that locking
problems in the jbd2 layer could be very hard to debug, so we need to
make sure we have some really good testing as we make any changes.
Not taking the j_state_lock spinlock in jbd2_stop_lock() was relatively
easy to prove to be safe, but I'm really worried about
start_this_handle() the locking around that is going to be subtle, and
it's not just the specific fields in the transaction and journal
handle.
And even with the ...
| Apr 9, 4:33 pm 2010 |
| Chen, Tim C | RE: ext4 dbench performance with CONFIG_PREEMPT_RT
Your patch did remove the contention on the j_state_lock for dbench
in my testing with 64 threads. The contention point now
moves dcache_lock, which is also another tricky bottleneck.
In our other testing with FFSB that creates/rename/remove a lot of directories,
we found that journal->j_revoke_lock was also heavily contended.
Tim--
| Apr 9, 4:48 pm 2010 |
| john stultz | RE: ext4 dbench performance with CONFIG_PREEMPT_RT
Nick Piggin's vfs scalability patches takes care of the dcache_lock
contention. I'm actually using them with the -rt patch in my testing
Yep. This also shows up in my -rt patch testing with Ted's patch.
thanks
-john
--
| Apr 9, 4:57 pm 2010 |
| Greg Freemyer | Re: EXT4_IOC_MOVE_EXT file corruption!
That implies to me that there is a missing block flush prior to a lock
being released. That should not be too hard to find by code
inspection.
As conceptually interested as I am in ext4_ioc_move_ext, I have not
really gone through the code with any detail. Maybe I'll contribute
by doing that.
Greg
--
| Apr 9, 10:15 am 2010 |
| Darrick J. Wong | Re: EXT4_IOC_MOVE_EXT file corruption!
It seems that if you mount the filesystem with -o sync this problem goes away.
--
| Apr 9, 9:20 am 2010 |
| previous day | today | next day |
|---|---|---|
| April 8, 2010 | April 9, 2010 | April 10, 2010 |
