Home » Mailing list archives » linux-ext4 » 2010 » April » 5

Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()

Previous thread: [GIT PULL] ext4 fixes by Theodore Ts'o on Wednesday, March 24, 2010 - 7:17 pm. (1 message)

Next thread: [PATCH 1/2] ext4: try to relieve ext4_mb_discard_group_preallocations() from hard work in simple way by jing zhang on Thursday, March 25, 2010 - 8:24 am. (2 messages)
[view original message]
From: jing zhang
Subject: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Thursday, March 25, 2010 - 7:54 am

From: Jing Zhang <zj.barak@gmail.com>

Date: Wed Mar 25  22:55:04   2010

Checking bug seems not at right place, and the function itself should
be inlined.

Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>

---

--- linux-2.6.32/fs/ext4/mballoc.c	2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc-10.c	2010-03-25 22:44:00.000000000 +0800
@@ -2786,9 +2786,7 @@ out_err:
 static void ext4_mb_normalize_group_request(struct ext4_allocation_context *ac)
 {
 	struct super_block *sb = ac->ac_sb;
-	struct ext4_locality_group *lg = ac->ac_lg;

-	BUG_ON(lg == NULL);
 	if (EXT4_SB(sb)->s_stripe)
 		ac->ac_g_ex.fe_len = EXT4_SB(sb)->s_stripe;
 	else
--


[ message continues ]
[view original message]
From: Aneesh Kumar K. V
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Friday, March 26, 2010 - 1:08 am

That BUG_ON is to ensure that the allocation context is actually having
a locality group which is needed for group allocation request.

-aneesh
--


[ message continues ]
[view original message]
From: jing zhang
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Friday, March 26, 2010 - 6:44 am

Please check
1, the 3 lines at the end of ext4_mb_group_or_file()
2, the function name of this patch

              - zj
--


[ message continues ]
[view original message]
From: Aneesh Kumar K. V
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Friday, March 26, 2010 - 7:27 am

What i wanted to mention was the BUG_ON is there to ensure that we don't
call ext4_mb_normalize_group_request on non group enabled allocation
context by programming mistake. Doing that would cause ac_g_ex.fe_len
to change. So that BUG_ON is there to capture a programming error. 

-aneesh
--


[ message continues ]
[view original message]
From: jing zhang
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Friday, March 26, 2010 - 7:37 am

Thank you, Aneesh, for good explanation in patience.

Again, good weekend.

Still in work?

        - zj
--


[ message continues ]
[view original message]
From: tytso
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Monday, April 5, 2010 - 5:48 am

This patch has been marked as rejected in patchwork.

-- Ted

--


[ message continues ]
[view original message]
From: jing zhang
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Tuesday, April 6, 2010 - 7:05 am

I accept what you decided, Mr. Theodore Ts'o.

And I want to learn a little about the score on the patchwork web
site, so please guide me to it if you like.

Thank you all, great maintainers and developers of GNU Linux, for
reviewing the patch I delivered.

                           - zj
--


[ message continues ]
[view original message]
From: tytso
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_normalize_group_request()
Date: Tuesday, April 6, 2010 - 10:01 am

http://patchwork.ozlabs.org/project/linux-ext4/list/

Yes, there's a huge backlog.  In general the most recent patches are
the ones that I worry about.  The oldest ones are there more for
archeological digging more than anything else.  Patch submitters
generally will ping me to remind me of a specific patch if there
hasn't been some kind of response in a few weeks...

       	    	      	 	       - Ted
--


[ message continues ]
Previous thread: [GIT PULL] ext4 fixes by Theodore Ts'o on Wednesday, March 24, 2010 - 7:17 pm. (1 message)

Next thread: [PATCH 1/2] ext4: try to relieve ext4_mb_discard_group_preallocations() from hard work in simple way by jing zhang on Thursday, March 25, 2010 - 8:24 am. (2 messages)