[PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christian Borntraeger
Date: Sunday, March 7, 2010 - 1:32 pm

I have an x86_64 kernel with i386 userspace. e4defrag fails on the
EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat
case. It seems that struct move_extent is compat save, only types
with fixed widths are used:
{
        __u32 reserved;         /* should be zero */
        __u32 donor_fd;         /* donor file descriptor */
        __u64 orig_start;       /* logical start offset in block for orig */
        __u64 donor_start;      /* logical start offset in block for donor */
        __u64 len;              /* block length to be moved */
        __u64 moved_len;        /* moved block length */
};

Lets just wire up EXT4_IOC_MOVE_EXT for the compat case.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
CCed: Akira Fujita <a-fujita@rs.jp.nec.com> 

---
 fs/ext4/ioctl.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -375,6 +375,8 @@ long ext4_compat_ioctl(struct file *file
 		break;
 	case EXT4_IOC_GROUP_ADD:
 		break;
+	case EXT4_IOC_MOVE_EXT:
+		break;
 	default:
 		return -ENOIOCTLCMD;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit co ..., Christian Borntraeger, (Sun Mar 7, 1:32 pm)
Re: defrag deployment status (was Re: [PATCH] ext4: allow ..., Christian Borntraeger, (Mon Mar 8, 12:53 am)
Re: defrag deployment status (was Re: [PATCH] ext4: allow ..., Christian Borntraeger, (Mon Mar 8, 9:00 am)
Re: defrag deployment status (was Re: [PATCH] ext4: allow ..., Valdis.Kletnieks, (Mon Mar 8, 12:38 pm)
[PATCH resend] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 3 ..., Christian Borntraeger, (Fri Mar 12, 12:01 am)