Home » Mailing list archives » linux-ext4 » 2010 » March » 7

Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_error() instead

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric Sandeen
Subject: Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_error() instead
Date: Saturday, March 6, 2010 - 10:51 pm

tytso@mit.edu wrote:


As the originator of the lower-case ext4_error and ext4_warning macros,
I don't much care.

I find the lower case more readable, but if the expectation in fs/extN is 
that ALL_MACROS_SHALL_BE_UPPER_CASE, that's fine by me.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/28] Ext4 patch queue for the 2.6.34 merge window., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 01/28] ext4: fix async i/o writes beyond 4GB to a s ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 02/28] ext4: Fix optional-arg mount options, Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 03/28] ext4: Add block validity check when truncati ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 04/28] ext4: Add new tracepoint for jbd2_cleanup_jo ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 05/28] ext4: Add new tracepoints to debug delayed a ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 06/28] ext4: Use slab allocator for sub-page sized ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 07/28] ext4: Use bitops to read/modify EXT4_I(inode ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 08/28] ext4: Reserve INCOMPAT_EA_INODE and INCOMPAT ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 09/28] ext4: move __func__ into a macro for ext4_wa ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 10/28] ext4: add missing error checking to ext4_exp ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 11/28] ext4: correctly calculate number of blocks f ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 12/28] jbd2: delay discarding buffers in journal_un ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 13/28] ext4: Fix BUG_ON at fs/buffer.c:652 in no jo ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 14/28] ext4: Add flag to files with blocks intentio ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 15/28] ext4: mount flags manipulation cleanup, Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 16/28] ext4: trivial quota cleanup, Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 17/28] jbd2: clean up an assertion in jbd2_journal_ ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 18/28] ext4: Fix fencepost error in chosing choosin ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 19/28] ext4: deprecate obsoleted mount options, Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 20/28] ext4: fix error handling in migrate, Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 21/28] ext4: explicitly remove inode from orphan li ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 22/28] ext4: Handle non empty on-disk orphan link, Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 23/28] ext4: make "offset" consistent in ext4_check ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 24/28] ext4: mechanical change on dio get_block cod ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 25/28] ext4: use ext4_get_block_write in buffer write, Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 26/28] ext4: Use direct_IO_no_locking in ext4 dio read., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_erro ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
[PATCH 28/28] ext4: Fix ext4_quota_write cross block bound ..., Theodore Ts'o, (Tue Mar 2, 11:18 am)
Re: [PATCH 00/28] Ext4 patch queue for the 2.6.34 merge wi ..., tytso, (Tue Mar 2, 11:26 am)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., Akira Fujita, (Wed Mar 3, 12:47 am)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., Leonard Michlmayr, (Wed Mar 3, 1:34 am)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., tytso, (Wed Mar 3, 10:52 am)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., Akira Fujita, (Wed Mar 3, 10:40 pm)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., Leonard Michlmayr, (Thu Mar 4, 2:44 pm)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., tytso, (Thu Mar 4, 3:08 pm)
[incomplete PATCH] ext4: avoid overflow in fiemap, Leonard Michlmayr, (Thu Mar 4, 3:28 pm)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., Eric Sandeen, (Thu Mar 4, 4:38 pm)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., Eric Sandeen, (Thu Mar 4, 4:47 pm)
Re: [PATCH 11/28] ext4: correctly calculate number of bloc ..., Leonard Michlmayr, (Fri Mar 5, 9:46 am)
Re: [PATCH 25/28] ext4: use ext4_get_block_write in buffer ..., Aneesh Kumar K. V, (Sat Mar 6, 5:48 am)
Re: [PATCH 04/28] ext4: Add new tracepoint for jbd2_cleanu ..., Aneesh Kumar K. V, (Sat Mar 6, 5:50 am)
Re: [PATCH 24/28] ext4: mechanical change on dio get_block ..., Aneesh Kumar K. V, (Sat Mar 6, 5:58 am)
Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_ ..., Aneesh Kumar K. V, (Sat Mar 6, 6:03 am)
Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_ ..., tytso, (Sat Mar 6, 7:45 pm)
Re: [incomplete PATCH] ext4: avoid overflow in fiemap, tytso, (Sat Mar 6, 8:38 pm)
Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_ ..., Eric Sandeen, (Sat Mar 6, 10:51 pm)
Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_ ..., Andreas Dilger, (Sun Mar 7, 10:36 am)
Re: [PATCH 27/28] ext4: Convert BUG_ON checks to use ext4_ ..., Frank Mayhar, (Mon Mar 8, 10:46 am)