| From | Subject | Date |
|---|---|---|
| Jan Kara | Re: [PATCH 2/4] ext4: mount flags manipulation cleanup
Looks good.
Acked-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
| Feb 2, 6:45 am 2010 |
| Jan Kara | Re: [PATCH 3/4] ext3: trivial quota cleanup
And this one is good as well. Merged.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
| Feb 2, 6:45 am 2010 |
| Jan Kara | Re: [PATCH 4/4] ext4: trivial quota cleanup
Looks good.
Acked-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
| Feb 2, 6:46 am 2010 |
| Jan Kara | Re: [PATCH 1/4] ext3: mount flags manipulation cleanup
Nice cleanup. Thanks. Merged into my tree...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
| Feb 2, 6:44 am 2010 |
| Dmitry Monakhov | [PATCH 2/4] ext4: mount flags manipulation cleanup
Replace intermediate EXT4_MOUNT_XXX flags manipulation to
corresponding macro.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext4/super.c | 31 +++++++++++++------------------
1 files changed, 13 insertions(+), 18 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 735c20d..e768a2c 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -796,10 +796,10 @@ static inline void ext4_show_quota_options(struct seq_file *seq,
if (sbi->s_qf_names[GRPQUOTA])
...
| Feb 2, 6:05 am 2010 |
| Dmitry Monakhov | [PATCH 3/4] ext3: trivial quota cleanup
The patch is aimed to reorganize and simplify quota code a bit.
Quota code is itself complex enouth, but we can make it more readable
in some places:
- Move quota option parsing to separate functions.
- Simplify old-quota and journaled-quota mix check.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext3/super.c | 121 ++++++++++++++++++++++++++++++------------------------
1 files changed, 67 insertions(+), 54 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index ...
| Feb 2, 6:05 am 2010 |
| Dmitry Monakhov | [PATCH 4/4] ext4: trivial quota cleanup
The patch is aimed to reorganize and simplify quota code a bit.
Quota code is itself complex enouth, but we can make it more readable
in some places:
- Move quota option parsing to separate functions.
- Simplify old-quota and journaled-quota mix check.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext4/super.c | 122 ++++++++++++++++++++++++++++++------------------------
1 files changed, 68 insertions(+), 54 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index ...
| Feb 2, 6:05 am 2010 |
| Dmitry Monakhov | [PATCH 1/4] ext3: mount flags manipulation cleanup
Replace intermediate EXT3_MOUNT_XXX flags manipulation to
corresponding macro.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext3/super.c | 47 ++++++++++++++++++++---------------------------
1 files changed, 20 insertions(+), 27 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index afa2b56..7950ff6 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -181,7 +181,7 @@ static void ext3_handle_error(struct super_block *sb)
if (!test_opt (sb, ERRORS_CONT)) ...
| Feb 2, 6:05 am 2010 |
| Aneesh Kumar K. V | Re: [PATCH 11/23] richacl: Move the xattr representation ...
Yes. We should be merging some of these patches into earlier patches. I
want to keep the patches separate at this point to enable Andreas to
find out the changes done to original path so that he should be able to
review them easily. But yes before we can merge this to upstream some
of this patches to be folded back to earlier patches.
-aneesh
--
| Feb 1, 10:35 pm 2010 |
| Aneesh Kumar K. V | Re: [PATCH 07/23] vfs: Add Posix acl to rich acl mapping ...
Exactly.
For ex:
/mnt# touch a
/mnt# getfacl a
# file: a
# owner: root
# group: root
user::rw-
group::r--
other::r--
/mnt# setfacl -m u:guest:rw a
/mnt# getfacl a
# file: a
# owner: root
# group: root
user::rw-
user:guest:rw-
group::r--
mask::rw-
other::r--
# umount /mnt/
# tune2fs -O richacl /dev/vdc
# mount /dev/vdc /mnt -o acl
# cd /mnt/
/mnt# getfacl a
# file: a
# acl format: richacl
# owner: root
# group: root
flags:pP <----- ...
| Feb 1, 10:22 pm 2010 |
| Aneesh Kumar K. V | Re: [PATCH 08/23] vfs: Add a flag to denote posix mapped ...
Incorrect in the sense of what user expected the mapping should be.
This flag is later used by the userspace to indicate that the returned
richacl is a mapped richacl from Posix. The sysadmin should be able to
look at the flag and make sure the acl values are what he expected it
to be and the mapping code didn't map it wrongly.
NOTE: If the user belong to multiple groups, posix acl evaluation will
look at the group for which the requested access mask is allowed and
then apply the ACL_MASK ...
| Feb 1, 10:33 pm 2010 |
| J. Bruce Fields | Re: [PATCH 08/23] vfs: Add a flag to denote posix mapped ...
It's not going to map wrongly--if it does, there's a bug, and we should
just fix the bug.
It's not reasonable to expect sysadmins to manually check mapped ACL's
to look for bugs in our mapping algorithm.
--
| Feb 2, 8:18 am 2010 |
| Eric Sandeen | [PATCH V2] xfstests: 223 - test file alignment on stripe ...
A first-cut test to ensure that files are well-aligned on filesystems
with stripe geometry.
Several sizes of stripe units are mkfs'd, and then files are written
and fallocated in various multiples of those stripe sizes.
Each file is checked to ensure that the first block is
stripe-aligned.
(Ideally, for any fragmented files, we should ensure that each
fragment start is well-aligned, but this does not do that yet)
(slightly unrelated: don't send scratch mkfs output to /dev/null,
we'd like ...
| Feb 2, 4:28 pm 2010 |
| Jan Kara | Re: Should we discard jbddirty bit if BH_Freed is set?
Thanks for the patch. For us to be able to merge the patch, we need a
Signed-off-by signature from you. Please add it in the next round of
When can merge the 'if' here. Also the comment above this code
Also here you have to update the comment above set_buffer_freed to match
the new reality.
Otherwise I'm fine with the patch.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
| Feb 2, 3:02 pm 2010 |
| bugzilla-daemon | [Bug 15074] Problem with quota on ext4
http://bugzilla.kernel.org/show_bug.cgi?id=15074
--- Comment #2 from Fabio Fantoni <fantonifabio@tiscali.it> 2010-02-02 17:49:13 ---
also with rc6, if can help when i active quota give me warning about quota
journaling support on ext4 not active, this update calltrace:
Feb 2 18:36:26 ns3093701 kernel: [ 155.133830] ------------[ cut here
]------------
Feb 2 18:36:26 ns3093701 kernel: [ 155.133832] WARNING: at
fs/quota/dquot.c:984 dquot_claim_space+0x98/0x109()
Feb 2 18:36:26 ...
| Feb 2, 10:49 am 2010 |
| previous day | today | next day |
|---|---|---|
| February 1, 2010 | February 2, 2010 | February 3, 2010 |
