Home » Mailing list archives » linux-ext4 » 2010 » November » 29

[PATCH 08/15] libext2fs: fix memory leak on error path

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Namhyung Kim
Subject: [PATCH 08/15] libext2fs: fix memory leak on error path
Date: Monday, November 29, 2010 - 1:55 am

io->name should be freed if ext2fs_file_open2() fails.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 lib/ext2fs/inode_io.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lib/ext2fs/inode_io.c b/lib/ext2fs/inode_io.c
index 4faaa48..bc934d3 100644
--- a/lib/ext2fs/inode_io.c
+++ b/lib/ext2fs/inode_io.c
@@ -157,11 +157,13 @@ static errcode_t inode_open(const char *name, int flags, io_channel *channel)
 				   &data->inode : 0, open_flags,
 				   &data->file);
 	if (retval)
-		goto cleanup;
+		goto cleanup_name;
 
 	*channel = io;
 	return 0;
 
+cleanup_name:
+	ext2fs_free_mem(&io->name);
 cleanup:
 	if (data) {
 		ext2fs_free_mem(&data);
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/15] e2fsprogs cleanups, Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 01/15 RESEND] libext2fs: fix potential build failur ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 02/15 RESEND] libext2fs: fix dubious code in ext2fs ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 03/15] mke2fs: simplify inode table block counting, Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 04/15] libext2fs: remove unnecessary casts to ext2f ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 05/15] libext2fs: fix dubious code in ext2fs_unmark ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 06/15] libext2fs: invalid EXT4_FEATURE_RO_COMPAT_HU ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 07/15] libext2fs: fix error path in ext2fs_update_b ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 08/15] libext2fs: fix memory leak on error path, Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 09/15] mke2fs: check return value of e2p_os2string(), Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 10/15] mke2fs.8.in: add missing &quot;big&quot; and &quot;huge&quot; us ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 11/15] mke2fs: fix determination of size_type, Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 12/15] mke2fs: add some error checks into PRS(), Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 13/15] mke2fs: fix potential memory leak in mke2fs_ ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 14/15] libext2fs: fix possible memory leak in write ..., Namhyung Kim, (Mon Nov 29, 1:55 am)
[PATCH 15/15] mke2fs.8.in: add ENVIRONMENT section, Namhyung Kim, (Mon Nov 29, 1:55 am)
Re: [PATCH 03/15] mke2fs: simplify inode table block counting, Lukas Czerner, (Tue Nov 30, 5:01 am)
Re: [PATCH 08/15] libext2fs: fix memory leak on error path, Lukas Czerner, (Tue Nov 30, 5:23 am)
Re: [PATCH 11/15] mke2fs: fix determination of size_type, Lukas Czerner, (Tue Nov 30, 5:33 am)
Re: [PATCH 12/15] mke2fs: add some error checks into PRS(), Lukas Czerner, (Tue Nov 30, 5:46 am)
Re: [PATCH 13/15] mke2fs: fix potential memory leak in mke ..., Lukas Czerner, (Tue Nov 30, 6:02 am)
Re: [PATCH 03/15] mke2fs: simplify inode table block counting, Namhyung Kim, (Wed Dec 1, 4:49 am)
Re: [PATCH 12/15] mke2fs: add some error checks into PRS(), Namhyung Kim, (Wed Dec 1, 5:03 am)
Re: [PATCH 13/15] mke2fs: fix potential memory leak in mke ..., Namhyung Kim, (Wed Dec 1, 5:32 am)
Re: [PATCH 11/15] mke2fs: fix determination of size_type, Namhyung Kim, (Wed Dec 1, 5:37 am)
Re: [PATCH 11/15] mke2fs: fix determination of size_type, Lukas Czerner, (Wed Dec 1, 8:46 am)
[PATCH v2 12/15] mke2fs: add some error checks into PRS(), Namhyung Kim, (Thu Dec 16, 2:40 am)
[PATCH v2 13/15] mke2fs: fix potential memory leak in mke2 ..., Namhyung Kim, (Thu Dec 16, 2:42 am)
Re: [PATCH v2 12/15] mke2fs: add some error checks into PRS(), Lukas Czerner, (Thu Dec 16, 5:19 am)
Re: [PATCH v2 13/15] mke2fs: fix potential memory leak in ..., Lukas Czerner, (Thu Dec 16, 5:21 am)
Re: [01/15, RESEND] libext2fs: fix potential build failure ..., Ted Ts'o, (Mon Dec 20, 8:04 am)
Re: [02/15, RESEND] libext2fs: fix dubious code in ext2fs_ ..., Ted Ts'o, (Mon Dec 20, 8:04 am)
Re: [PATCH 03/15] mke2fs: simplify inode table block counting, Ted Ts'o, (Mon Dec 20, 8:44 am)
Re: [PATCH 04/15] libext2fs: remove unnecessary casts to e ..., Ted Ts'o, (Mon Dec 20, 8:50 am)
Re: [PATCH 05/15] libext2fs: fix dubious code in ext2fs_un ..., Ted Ts'o, (Mon Dec 20, 8:54 am)
Re: [PATCH 06/15] libext2fs: invalid EXT4_FEATURE_RO_COMPA ..., Ted Ts'o, (Mon Dec 20, 8:55 am)
Re: [PATCH 07/15] libext2fs: fix error path in ext2fs_upda ..., Ted Ts'o, (Mon Dec 20, 9:01 am)
Re: [PATCH 08/15] libext2fs: fix memory leak on error path, Ted Ts'o, (Tue Dec 21, 4:06 pm)
Re: [PATCH 09/15] mke2fs: check return value of e2p_os2str ..., Ted Ts'o, (Tue Dec 21, 4:13 pm)
Re: [PATCH 10/15] mke2fs.8.in: add missing &quot;big&quot; and &quot;huge ..., Ted Ts'o, (Tue Dec 21, 4:45 pm)
Re: [PATCH 11/15] mke2fs: fix determination of size_type, Ted Ts'o, (Tue Dec 21, 4:45 pm)
Re: [PATCH v2 12/15] mke2fs: add some error checks into PRS(), Ted Ts'o, (Tue Dec 21, 6:34 pm)
Re: [PATCH 14/15] libext2fs: fix possible memory leak in w ..., Ted Ts'o, (Wed Dec 22, 8:43 am)