| From | Subject | Date |
|---|---|---|
| Eric Sandeen | Re: ext3: ext4: Using uninitialized value
that was introduced with:
commit acfa1823d33859b0db77701726c9ca5ccc6e6f25
Author: Andreas Dilger <adilger@clusterfs.com>
Date: Thu Jun 23 00:09:45 2005 -0700
[PATCH] Support for dx directories in ext3_get_parent (NFSD)
--
| Oct 13, 9:13 am 2010 |
| Roman Borisov | ext3: ext4: Using uninitialized value
Hello,
Could you clarify is there a bug in fs/ext4/namei.c,
ext4_dx_find_entry() and fs/ext4/namei.c, ext3_dx_find_entry()?
<code>
static struct buffer_head * ext3_dx_find_entry(struct inode *dir,
...
struct dx_hash_info hinfo;
...
if (namelen > 2 || name[0] != '.'|| (namelen == 2 && name[1] != '.')) {
if (!(frame = dx_probe(entry, dir, &hinfo, frames, err)))
return NULL;
} else {
frame = frames;
frame->bh = NULL; /* for dx_release() */
frame->at = (struct dx_entry *)frames; /* hack ...
| Oct 13, 7:40 am 2010 |
| Andreas Dilger | Re: ext3: ext4: Using uninitialized value
Right - it is important to note that the index root block is a "fake" directory block which has just the "." and ".." entries at the beginning (with the ".." spanning the rest of the block), and the rest of the block is holding the index entries. For a directory index to even exist, it HAS to have the "." and ".." entries in the first block, or there is no place to put the index.
Cheers, Andreas
--
| Oct 13, 11:56 am 2010 |
| Ted Ts'o | Re: [PATCH RFC 0/3] Block reservation for ext3
We ultimately decided to do two different things for ENOSPC versus
EDQUOTA in ext4. For quota overflow we just assume that the number of
metadata blocks won't be that many, and just allow them to go over
quota. For ENOSPC, we would force writeback to see if it would free
space, and ultimately we would drop out of delayed allocation mode
when we were close to running out of space (and for non-root users we
would depend on the 5% blocks reserved for root).
Yeah, that means if root ...
| Oct 12, 5:17 pm 2010 |
| Amir G. | Re: [PATCH RFC 0/3] Block reservation for ext3
On Wed, Oct 13, 2010 at 10:49 AM, Amir G.
Here is the indirect allocation patch.
The following debugfs dump shows the difference between a 1G file
allocated by dd (indirect interleaved with data) and by mmap (indirect
sequential before data).
(I did not test performance and I ignored SIGBUS at the end of mmap
file allocation)
debugfs: stat dd.1G
Inode: 15 Type: regular Mode: 0644 Flags: 0x0
Generation: 4035748347 Version: 0x00000000
User: 0 Group: 0 Size: ...
| Oct 13, 9:14 am 2010 |
| Amir G. | Re: [PATCH RFC 0/3] Block reservation for ext3
---------- Forwarded message ----------
From: Amir Goldstein <amir73il@gmail.com>
Date: Wed, Oct 13, 2010 at 10:44 AM
Subject: Re: [PATCH RFC 0/3] Block reservation for ext3
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ted Ts'o
<tytso@mit.edu>, linux-ext4@vger.kernel.org
How about allocating *only* the indirect blocks on page fault.
IMHO it seems like a fair mixture of high quota accuracy, low
complexity of the accounting code and low file fragmentation ...
| Oct 13, 1:49 am 2010 |
| previous day | today | next day |
|---|---|---|
| October 12, 2010 | October 13, 2010 | October 14, 2010 |
