Home » Mailing list archives » linux-ext4 » 2009 » July » 3

[PATCH] ext4: Add a missing return in ext4_ext_calc_credits_for_single_extent

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Aneesh Kumar K.V <aneesh.kumar@...>
To: <cmm@...>, <tytso@...>, <sandeen@...>
Cc: <linux-ext4@...>, Aneesh Kumar K.V <aneesh.kumar@...>
Subject: [PATCH] ext4: Add a missing return in ext4_ext_calc_credits_for_single_extent
Date: Friday, July 3, 2009 - 6:55 am

When we have space in the extent tree leaf node we should be able to
insert the extent with much less journal credits. The code was doing
proper calculation but missed a return statement.

Reported-by:Andreas Dilger <adilger@sun.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 fs/ext4/extents.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index f9ab60f..3e8889f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1977,6 +1977,7 @@ int ext4_ext_calc_credits_for_single_extent(struct inode *inode, int nrblocks,
 			 */
 			/* 1 bitmap, 1 block group descriptor */
 			ret = 2 + EXT4_META_TRANS_BLOCKS(inode->i_sb);
+			return ret;
 		}
 	}
 
-- 
1.6.3.2.363.gc5764

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] ext4: Add a missing return in ext4_ext_calc_credits_..., Aneesh Kumar K.V, (Fri Jul 3, 6:55 am)
Re: [PATCH] ext4: Add a missing return in ext4_ext_calc_cred..., Theodore Tso, (Sun Jul 5, 11:13 pm)