Home » Mailing list archives » linux-ext4 » 2008 » November » 13

Re: [RFC PATCH 14/17] super->s_*_blocks_count -> ext2fs_*_blocks_count()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andreas Dilger
Subject: Re: [RFC PATCH 14/17] super->s_*_blocks_count -> ext2fs_*_blocks_count()
Date: Thursday, November 13, 2008 - 1:24 pm

On Nov 11, 2008  19:43 -0800, Valerie Aurora Henson wrote:

Along with changes like this (and the similar ACL fix) I'd prefer that we
rename the old superblock field to be "s_block_count_lo" and put a comment
there referencing the accessor functions so that compilation will fail
and it is clear what needs to be fixed.

As you can see from this patch, even though ext2fs_blocks_count() predates
the 64-bit patches, it isn't used very widely.  Landing other patches
to e2fsprogs may run the risk of only accessing the low 32 bits of the
size/count/acl/etc because they were developed before 64-bit support
was added.

Since it isn't yet common to be able to test > 32-bit blocks
these bugs may go unnoticed for some time.  It would be nice to be able
to test 64-bit support easily with e2fsprogs.  Maybe truncate file
to > 16TB in size (abort if underlying filesystem isn't able to do this),
use "lazy_bg" or equivalent to avoid writing many GB of data into the
sparse file, then run e2fsck on it after putting some files at the end.
This could probably be done by the "script" support in "make check".


Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC PATCH 08/17] Turn on new bitmaps in e2fsck and mke2fs, Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
[RFC PATCH 09/17] Add progress bar for allocating block ta ..., Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
[RFC PATCH 10/17] signed int -> blk64_t to fix bugs at 2^3 ..., Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
[RFC PATCH 11/17] Fix overflow in calculation of total fil ..., Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
[RFC PATCH 12/17] Add ext2fs_block_iterate3 (from Ted), Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
[RFC PATCH 13/17] Support 48-bit file acl blocks, Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
[RFC PATCH 14/17] super->s_*_blocks_count -> ext2fs_*_bloc ..., Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
[RFC PATCH 15/17] Convert to inode/block/bitmap/table loc( ..., Valerie Aurora Henson, (Tue Nov 11, 8:43 pm)
Re: [RFC PATCH 09/17] Add progress bar for allocating bloc ..., Andreas Dilger, (Thu Nov 13, 12:54 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Andreas Dilger, (Thu Nov 13, 12:57 pm)
Re: [RFC PATCH 11/17] Fix overflow in calculation of total ..., Andreas Dilger, (Thu Nov 13, 1:04 pm)
Re: [RFC PATCH 13/17] Support 48-bit file acl blocks, Andreas Dilger, (Thu Nov 13, 1:14 pm)
Re: [RFC PATCH 14/17] super->s_*_blocks_count -> ext2fs_*_ ..., Andreas Dilger, (Thu Nov 13, 1:24 pm)
Re: [RFC PATCH 15/17] Convert to inode/block/bitmap/table ..., Andreas Dilger, (Thu Nov 13, 1:26 pm)
Re: [RFC PATCH 13/17] Support 48-bit file acl blocks, Valerie Aurora Henson, (Thu Nov 13, 7:30 pm)
Re: [RFC PATCH 11/17] Fix overflow in calculation of total ..., Valerie Aurora Henson, (Thu Nov 13, 7:34 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Valerie Aurora Henson, (Thu Nov 13, 7:38 pm)
Re: [RFC PATCH 09/17] Add progress bar for allocating bloc ..., Valerie Aurora Henson, (Thu Nov 13, 7:45 pm)
64-bit inode support in e2fsprogs? (was Re: [RFC PATCH 11/ ..., Valerie Aurora Henson, (Thu Nov 13, 8:10 pm)
Re: [RFC PATCH 14/17] super->s_*_blocks_count -> ext2fs_*_ ..., Valerie Aurora Henson, (Thu Nov 13, 8:25 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Eric Sandeen, (Thu Nov 13, 8:42 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Valerie Aurora Henson, (Thu Nov 13, 8:54 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Eric Sandeen, (Thu Nov 13, 9:04 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Theodore Tso, (Fri Nov 14, 7:24 am)
Re: [RFC PATCH 14/17] super->s_*_blocks_count -> ext2fs_*_ ..., Eric Sandeen, (Fri Nov 14, 9:24 am)
Re: 64-bit inode support in e2fsprogs? (was Re: [RFC PATCH ..., Andreas Dilger, (Fri Nov 14, 1:32 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Andreas Dilger, (Fri Nov 14, 1:35 pm)
Re: [RFC PATCH 10/17] signed int -> blk64_t to fix bugs at ..., Theodore Tso, (Sun Nov 16, 8:06 am)