[ath5k-devel] [PATCH 5/5] ath5k: write PCU registers on initial reset

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linville@...>, <jirislaby@...>, <mickflemm@...>, <lrodriguez@...>
Cc: <ath5k-devel@...>, <linux-wireless@...>, <stable@...>
Date: Saturday, July 4, 2009 - 12:59 pm

Commit d7dc100374df0c21afd8a198336ecd7999697159, "Ath5k: unify resets"
introduced a regression into 2.6.28 where the PCU registers are never
initialized, due to ath5k_reset() always passing true for change_channel.
We subsequently program a lot of these registers but several may start
in an unknown state.

Cc: stable@kernel.org
Reported-by: Forrest Zhang
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 3f55e90..80ae38d 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2687,7 +2687,7 @@ ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan)
sc->curchan = chan;
sc->curband = &sc->sbands[chan->band];
}
- ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, true);
+ ret = ath5k_hw_reset(ah, sc->opmode, sc->curchan, chan == NULL);
if (ret) {
ATH5K_ERR(sc, "can't reset hardware (%d)\n", ret);
goto err;
--
1.6.2.5

_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[ath5k-devel] [PATCH 0/5] ath5k updates, Bob Copeland, (Sat Jul 4, 12:59 pm)
[ath5k-devel] [PATCH 5/5] ath5k: write PCU registers on init..., Bob Copeland, (Sat Jul 4, 12:59 pm)