Looks good to me. Thanks for finding and fixing it! --

Unify error handling by treating errors from Perl (and thrown early in process using 'die STRING'), and errors from gitweb in the same way. This means that in both cases error page is generated after an error is caught in run() subroutine. die_error() subroutine is now split into three: gen_error() which massages parameters (escaping HTML, turning HTTP status number into full HTTP status code), die_error() which uses gen_error() and just throws an error (and does not generate an error page), ...

I was not sure how Perl reacts to ENOSPC (No space left on device), which I think it is only error that can be generated in flight as cache is being generated (or as gitweb output is printed i.e. sent to browser and captured/tee-ed i.e. saved to cache entry file), so I have checked this (using loopback to create small filesystem). The outcomes one worry about are the following: * Perl dies during printing - this leads to broken page send to browser, and no cache entry generated * Perl ...

As Junio already said, please provide a real name for the sign-off. But I also found the commit message and content confusing, probably because I haven't programmed Pascal for 15 years. You said But the last line very conspicuously already mentions 'class', so why does it fail? I had to look up a bit of Pascal syntax. Google helped with http://www.freepascal.org/docs-html/ref/ref.html which answers this. Also, as stated in SubmittingPatches, we generally word the messages as ...

Isn't that how export works in all Bourne-style shells? For example: $ env var=outside dash -c ' var=inside; dash -c "echo \$var" ' inside $ Maybe in the failing case SHELL was not exported but just set to /bin/false in .bashrc or similar? --

The explanation is in the comment right above the modification in the (my bad, I wrote this SHELL= without exporting it. Since bash re-exports already exported variables when they are assigned, and my /bin/sh points to bash, I didn't notice) -- Matthieu Moy http://www-verimag.imag.fr/~moy/ --

I understand that. But is the second part of requirement is such a large problem? I remember, somebody advised me to use this tool, when I reported some bug some time (maybe a year) ago. But, I'm afraid, I do not know how to separate my deployment tool logic (which reproduces the bug) from the repository data. If I did know, I'd come up with a minimal example already. Nothing trivial "along the lines", that I tried so far, does reproduce it. Alexander. --

Committing few megabytes of data several times per second is Thank you for your opinion. I view this particular situation as follows: 1. I found a reproducible case for a hard to catch bug in Git. (This is a bug in Git, not in my build process.) This bug in its intermittent form annoyed me for quite some time — several months at least — and is likely to annoy other users. (I'm not *that* unique!) 2. I can live happily with sleep(0.2) in my deployment code (while this is not very ...

This should have said "if (!val)". Sorry for the confusion. --

AFAICS this is partly about spelling the variables in lowercase instead of all-caps. Wouldn't it be nicer to simply downcase *all* variables, so that the [...] -- Thomas Rast trast@{inf,student}.ethz.ch --

AFAICS rebase -i currently only uses the strategy when dealing with multiple parents, i.e., in --preserve-merges mode. I think git-cherry-pick needs to learn about the -s and -X options, and then it'll be a simple matter of passing them along. -- Thomas Rast trast@{inf,student}.ethz.ch --

Just a style, but I find if test -n "$split_submodule" then sub_differs= sub_parents= sub_commit= easier to read. Not a biggie, as the neighbourhood in the script already if test -z "$parents" && test -n "$submodule" then sub_differs=t ... so we can just pick from the first parent and know all of them are the same (could be empty which also is fine). Good. --

Why not "xmac/gen/* -diff" or even "xmac/gen/*.xmac -diff"? --

Heh, I didn't know about the "both" case. That is probably unintended misfeature that would not hurt but would not be useful in practice either Just for the record, "Avoid dqdq in the middle" was never the motivation; you can run two no_dq invocations and put dq around the result yourself. The main motivation for using this, before the strbuf was widely used, was to avoid having to allocate memory only to call quote_c_style, because it "... if you are preparing a command line to give to ...

This is a "reply all" from thunderbird. This looks like it is doing the cc correctly... v/r, Neal --

Also because the repositories are world readable. I don't know what I was thinking; I should get some sleep. Thanks again for reporting and good luck. Jonathan --

bind(3, {sa_family=AF_INET, sin_port=htons(9418), sin_addr=inet_addr("0.0.0.0")}, 16) = -1 EADDRINUSE (Address already in use) --

Date: Fri, 3 Sep 2010 19:44:39 -0500 With v1.5.0-rc0~169 (gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url, 2006-12-04), the logo URI to be written to Atom feeds was corrected but the case of no logo forgotten. Acked-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 4779618..c65af1a 100755 --- ...

Why do you think that git-instaweb can benefit from not having logo? You need gitweb.css anyway, so it is not much more trouble to serve corelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81; IIRC gitweb requires something later than 5.8.0 for good support of For what it is worth it: Acked-by: Jakub Narebski <jnareb@gmail.com> -- Jakub Narebski Poland --

New year's reminder: register your vote for native git support in google code -- go to: http://code.google.com/p/support/issues/detail?id=2454 and click the star in front of "Issue 2454: native git support" -miles -- Do not taunt Happy Fun Ball. --

I assume the correct permissions for your tracked files should be 2750? If so, then here's what I would do: 1. First make a copy of your repo and test these steps on the copy: e.g. bare repo: cp -rvp repo.git repocopy.git non-bare-repo: cp -rvp worktree worktreecopy 2. Then cd to the parent of the objects dir in you git repo: e.g. bare repo: cd repocopy.git non-bare repo: cd worktreecopy/.git 3. Then change the permissions of your objects dir: chmod -R 2750 ...

Looks like gitk doesn't like the "-rc0" suffix. $ git --version git version 1.7.4-rc0 $ gitk Error in startup script: expected version number but got "1.7.4-rc0" while executing "package vcompare $git_version "1.6.6.2"" (file "/usr/local/bin/gitk" line 1) I temporarily fixed it by hard-coding the version string: diff --git a/gitk-git/gitk b/gitk-git/gitk index e82c6bf..367446e 100644 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -11581,7 +11581,7 @@ if {![info exists have_ttk]} ...

After more carefully re-reading gitignore(5) I think that now I get it. I presume that is is not possible to match certain pattern occurring *anywhere* in the path. Would it be possible to extend pattern format to include double-star wildcard that matches anything including slashes ? Like: **/whatever/** Many tools (in java at least) and libraries support such extension to globs. Unfortunately standard fnmatch(3) that's used by git is not one of them, but glibc's implementation ...

Cheers, Michael --

Not really. I'd rather see a handful of test cases added to t0003 to help interested parties to see what is broken and what is not. Quoting from Marcin's other message, assuming that "Patterns" are stored With slashes, so this is anchored at the toplevel of the working tree, and The same as above;, the leading '/' is only to make it explicit that it is This shouldn't match unless it appears in d1/.gitattributes. The presense of '/' makes the pattern anchored to the directory it ...

Does git-am need symmetric support to decode the message? -- Thomas Rast trast@{inf,student}.ethz.ch --

The script git-send-email.perl has been modified in order to add support for messages with S/MIME format. First, the message body is written in a temporary file and signed by OpenSSL with the X.509 certificate provided by the user. Then the returned content is added to the previously parsed header and the message is sent as the same for unsigned messages. Usage: git send-email -sign -signing-cert </path/of/PEM> <other options> Signed-off-by: Roberto Sassu ...

For me the biggest feature that I am looking for is the automatic merging of commits, and second, having a branch that puts my collection of patches/commits ahead of the Pd master so that its easy to manage the patches. I don't think I see how I could do that with this multiple branches idea. Is that possible? .hc ---------------------------------------------------------------------------- I have the audacity to believe that peoples everywhere can have three meals a ...

t/README recommends chaining test assertions. Signed-off-by: Antonio Ospite <ospite@studenti.unina.it> --- Hi sorry for the delay, the only change wrt. v1 is the use of test_might_fail with git config --unset as requested by Jonathan. Note that in t9001-send-email.sh and other tests git config --unset is used without the test_might_fail handler some other times, you might wat to check this. Thanks and best regards, Antonio Ospite http://ao2.it t/t9001-send-email.sh | 8 ...