Re: [PATCH 2/3] Fixes bug: git-svn: svn.pathnameencoding is not respected with dcommit/set-tree

Previous thread: [PATCH 0/5] Custom extended SHA-1 syntax by =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= on Friday, December 24, 2010 - 7:07 am. (6 messages)

Next thread: [PATCH 3/3] Fixes bug: GIT_PS1_SHOWDIRTYSTATE is no not respect diff.ignoreSubmodules config variable by Zapped on Friday, December 24, 2010 - 6:20 pm. (10 messages)
From: Zapped
Date: Friday, December 24, 2010 - 6:20 pm

git-svn dcommit/set-tree fails when svn.pathnameencoding is set for native OS encoding (e.g. cp1251 for Windows) though git-svn fetch/clone works well

Signed-off-by: Zapped <zapped@mail.ru>
---
 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 757de82..399bf4c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -4451,6 +4451,7 @@ sub new {
 	$self->{path_prefix} = length $self->{svn_path} ?
 	                       "$self->{svn_path}/" : '';
 	$self->{config} = $opts->{config};
+	$self->{pathnameencoding} = Git::config('svn.pathnameencoding');
 	return $self;
 }
 
-- 
1.7.3.4.3.g3f811

--

From: Thomas Rast
Date: Tuesday, January 4, 2011 - 10:18 am

I'll let Eric judge whether loading the encoding here is the right
fix, but here too the commit message states only what is broken, not
why you fixed it that way.  Can you elaborate a bit?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
--

Previous thread: [PATCH 0/5] Custom extended SHA-1 syntax by =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= on Friday, December 24, 2010 - 7:07 am. (6 messages)

Next thread: [PATCH 3/3] Fixes bug: GIT_PS1_SHOWDIRTYSTATE is no not respect diff.ignoreSubmodules config variable by Zapped on Friday, December 24, 2010 - 6:20 pm. (10 messages)