git mailing list

FromSubjectsort iconDate
=?UTF-8?q?Nguy=E1=BB ...
[PATCH] pack-object: trim memory usage a tiny bit
This shrinks struct object_entry from 88 bytes to 80 bytes on my 32 bit machine. So that would be 12M less on linux-2.6.git (1.6M objects) Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- Don't know if it's really worth a patch.. builtin/pack-objects.c | 18 ++++++++++-------- 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 0e81673..398c0bb 100644 --- a/builtin/pack-objects.c +++ ...
Aug 6, 10:00 am 2010
Sverre Rabbelier
Re: [PATCH] pack-object: trim memory usage a tiny bit
Heya, Either way, some explanation would be nice. -- Cheers, Sverre Rabbelier --
Aug 6, 4:58 pm 2010
Shawn O. Pearce
[PATCH] smart-http: Don't deadlock on server failure
If the remote HTTP server fails (e.g. returns 404 or 500) when we posted the RPC to it, we won't have sent anything to the background Git process that is supposed to handle the stream. Because we didn't send anything, its waiting for input from remote-curl, and remote-curl cannot read its response payload because doing so would lead to a deadlock. Send the background task EOF on its input before we try to read its response back, that way it will break out of its read loop and ...
Aug 6, 2:19 pm 2010
=?UTF-8?q?=C3=86var= ...
[PATCH 0/3] tests: Better prerequisite handling & docume ...
There were some useful nuggets in the "Tests in Cygwin" thread from May last year that I've dug out and improved. This series adds support for multiple test prerequisite, and improves the t/README documentation by adding a "Prerequisites" section. There's also a small fix to the raw test output. Ævar Arnfjörð Bjarmason (3): test-lib: Add support for multiple test prerequisites test-lib: Print missing prerequisites in test output t/README: Document the predefined test prerequisites ...
Aug 6, 2:19 pm 2010
=?UTF-8?q?=C3=86var= ...
[PATCH 2/3] test-lib: Print missing prerequisites in tes ...
Change the test output to print needed prerequisites as part of the TAP. This makes it easy to see at a glance why a test was skipped. Before: ok 7 # skip <message> ok 9 # skip <message> After: ok 7 # skip <message> (prereqs: DONTHAVEIT) ok 9 # skip <message> (prereqs: HAVEIT,DONTHAVEIT) This'll also be useful for smoke testing output, where the developer reading the output may not be familiar with the system where tests are being skipped. Signed-off-by: Ævar ...
Aug 6, 2:19 pm 2010
=?UTF-8?q?=C3=86var= ...
[PATCH 3/3] t/README: Document the predefined test prere ...
The README for the test library suggested that you grep the test-lib.sh for test_set_prereq to see what the preset prerequisites were. Remove that bit, and write a section explaining all the preset prerequisites. Most of the text was lifted from from Junio C Hamano and Johannes Sixt, See the "Tests in Cygwin" thread in May 2009 for the originals: http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118385 ...
Aug 6, 2:19 pm 2010
=?UTF-8?q?=C3=86var= ...
[PATCH 1/3] test-lib: Add support for multiple test prer ...
Change the test_have_prereq function in test-lib.sh to support a comma-separated list of prerequisites. This is useful for tests that need e.g. both POSIXPERM and SANITY. The implementation was stolen from Junio C Hamano and Johannes Sixt, the tests and documentation were not. See the "Tests in Cygwin" thread in May 2009 for the originals: http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118385 ...
Aug 6, 2:19 pm 2010
René Scharfe
[PATCH] notes: allow --dry-run for -n and --verbose for -v
For consistency with other git commands, let the prune subcommand of git notes accept the long options --dry-run and --verbose for the respective short ones -n and -v. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- Documentation/git-notes.txt | 2 ++ builtin/notes.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt index 5540af5..2981d8c 100644 --- ...
Aug 6, 1:28 pm 2010
René Scharfe
[PATCH] prune: allow --dry-run for -n and --verbose for -v
For consistency with other git commands, let git prune accept the long options --dry-run and --verbose for the respective short ones -n and -v. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> --- Documentation/git-prune.txt | 2 ++ builtin/prune.c | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/git-prune.txt b/Documentation/git-prune.txt index 15cfb7a..4d673a5 100644 --- a/Documentation/git-prune.txt +++ ...
Aug 6, 1:28 pm 2010
René Scharfe
Re: [PATCH] prune: allow --dry-run for -n and --verbose for -v
Indeed. Adding a helptext parameter to OPT__DRY_RUN à la OPT__COLOR would make it usable here as well as in commit.c and fetch.c. Similar changes could help OPT__VERBOSE and OPT__QUIET. Their standard helptexts don't add a lot of information.. René --
Aug 6, 2:41 pm 2010
Jonathan Nieder
Re: [PATCH] prune: allow --dry-run for -n and --verbose for -v
For the curious: avoiding OPT__DRY_RUN allows us to give a better which makes sense to me. Thanks. --
Aug 6, 2:04 pm 2010
Ævar Arnfjörð Bjarmason
Re: Bizarro race conditions in the Git Makefile
Yes that works. I thought that -j $n would mean that make would use $n jobs to complete the first target, then move onto the next. Not execute them all in paralell. Thanks, and I have no idea about those Makefile/Perl changes. --
Aug 6, 2:40 pm 2010
Ævar Arnfjörð Bjarmason
Bizarro race conditions in the Git Makefile
"Doctor, when I poke my eye like this it hurts" -"So don't do that then" If you run the Git Makefile (with GNU Make 3.81) in parallel for long enough you'll get some interesting breakages. Those interested in poking their eyes can try: while nice -n 30 make -j 15 clean all CFLAGS=-O0 CC=gcc; do 1; done These suggest that we have some bugs in our Makefile dependencies, but since I haven't found what they are I'm just going to post the symptoms. The first example is the ...
Aug 6, 12:44 pm 2010
Jonathan Nieder
Re: Bizarro race conditions in the Git Makefile
You are asking make to simultaneously build and unbuild everything. It does not really surprise me that it gets confused. Does while nice -n 30 make -j 15 clean CFLAGS=-O0 CC=gcc && nice -n 30 make -j 15 all CFLAGS=-O0 CC=gcc do : done Maybe something like the following is needed to protect against interrupted builds (not the problem you reported, but this reminds me). diff --git a/perl/Makefile b/perl/Makefile index 4ab21d6..eef7ee5 100644 --- a/perl/Makefile +++ ...
Aug 6, 2:14 pm 2010
Jonathan Nieder
Re: Decompressing a tree to a location other than the wo ...
I don’t know if it is plumbing, but "git archive" is very useful for that. $ git archive HEAD^:Documentation | (cd elsewhere && tar xf -) Hope that helps, Jonathan --
Aug 6, 11:43 am 2010
Joshua Shrader
Decompressing a tree to a location other than the workin ...
git checkout allows one to checkout a particular version of a certain path in the working directory. Are there accessible plumbing commands that can be used to accomplish the same thing, but change the target directory. For example, if I wanted to checkout a certain path, but wanted to check it out somewhere external to my working directory / repository? Thanks, Josh --
Aug 6, 11:43 am 2010
Jakub Narebski
Re: Decompressing a tree to a location other than the wo ...
Porcelain way: check out first example in git-archive(1) manpage EXAMPLES ======== git archive --format=tar --prefix=junk/ HEAD | (cd /var/tmp/ && tar xf -) Create a tar archive that contains the contents of the latest commit on the current branch, and extract it in the /var/tmp/junk directory. Plumbing way: after preparing index (it can be separate file than .git/index), use "git checkout-index" as desceived in second example on manpage: EXAMPLES ...
Aug 6, 12:58 pm 2010
Chris Packham
getting an interpreted remote url for script use
Hi, I have a script that sends an email to a developer when someone applies their patch (I know there are other server-side hooks that can be used for this, but there are infrastructure reasons why these can't be used easily). Among other things my script tries to take the URL of the remote and convert it to a http URL that is pointing to our internal server running gitweb. The conversion is a simple s|ssh://|http://to-gitweb| At the moment the script parses the output of 'git remote show ...
Aug 6, 10:19 am 2010
Elijah Newren
[PATCH 0/2] Fix spurious conflicts with pull --rebase
This patch series fixes git pull --rebase failing to detect if "local" patches are already upstream in cases where the upstream repository is not itself rebased. Also in the non-rebased upstream case, this series avoids checking/applying more patches than needed (i.e. avoids having rebase work on commits which are already reachable from upstream). It would be nice to make 'git pull --rebase' able to detect if patches being applied are already part of upstream in cases where the ...
Aug 6, 7:05 am 2010
Elijah Newren
[PATCH 1/2] t5520-pull: Add testcases showing spurious c ...
Signed-off-by: Elijah Newren <newren@gmail.com> --- t/t5520-pull.sh | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh index 319e389..8f76829 100755 --- a/t/t5520-pull.sh +++ b/t/t5520-pull.sh @@ -160,4 +160,63 @@ test_expect_success 'pull --rebase works on branch yet to be born' ' test_cmp expect actual ' +test_expect_success 'setup for detecting upstreamed changes' ...
Aug 6, 7:05 am 2010
Elijah Newren
[PATCH 2/2] pull --rebase: Avoid spurious conflicts and ...
Prior to c85c79279df2c8a583d95449d1029baba41f8660, pull --rebase would run git rebase $merge_head which resulted in a call to git format-patch ... --ignore-if-in-upstream $merge_head..$cur_branch This had two nice qualities when upstream isn't rebased: (1) "only" the patches in $merge_head..$cur_branch would be applied, and (2) patches could be dropped/ignored if they had already been applied. But this did not work well when upstream is rebased, since in that case $merge_head..$cur_branch ...
Aug 6, 7:05 am 2010
Asgeir S. Nilsen
[PATCH] contrib: Replaced /bin/sh with /bin/bash to make ...
Signed-off-by: Asgeir S. Nilsen <asgeir@twingine.no> --- contrib/ciabot/ciabot.sh | 2 +- contrib/examples/git-checkout.sh | 2 +- contrib/examples/git-clean.sh | 2 +- contrib/examples/git-clone.sh | 2 +- contrib/examples/git-commit.sh | 2 +- contrib/examples/git-fetch.sh | 2 +- contrib/examples/git-gc.sh | 2 +- contrib/examples/git-ls-remote.sh | 2 +- contrib/examples/git-merge.sh | 2 +- ...
Aug 6, 5:56 am 2010
Junio C Hamano
Re: [PATCH] contrib: Replaced /bin/sh with /bin/bash to ...
Thanks. The ones in contrib/examples used to be part of git and they were meant to get their shebang "#!/bin/sh" line replaced by the toplevel Makefile to whatever shell suitable on the platform. As you already know, /bin/sh on Solaris is non-POSIX and we recommend people to use a POSIX compilant shell. The current Makefile suggests /bin/bash on Solaris, but either ksh or /usr/xpg[46]/bin/sh should work. So a NAK on contrib/examples/ part. And replacing /bin/sh with /bin/bash for ...
Aug 6, 9:00 am 2010
PCMan
How to replace master branch of a repo with that of anot ...
Hello, I want to rewrite a program totally from scratch rather than branching from current one. So I created a new repo for it and do the development there. Now it's finished and I want to replace the old program with it. Is it possible to replace the master branch of the old repo with the code in this new repo? I want to move the old code to a separate branch for backup, and replace the master branch with the master branch of the new repo. Since git rm -r * than git add all new files will lost ...
Aug 6, 12:38 am 2010
Ramkumar Ramachandra
Re: How to replace master branch of a repo with that of ...
Hi, In your old repository: $ git checkout master # Switch to branch master $ git checkout -b backup # Create a branch backup of master $ git remote add new <new_repository_url> # "new" is the name of the remote $ git fetch new # Fetch all the objects from the remote "new" $ git checkout master # Get ready to rewrite master $ git reset --hard new/master # Use `reset --hard` with extreme caution $ git checkout backup # Your backup is safe here $ # Done! -- Ram --
Aug 6, 1:07 am 2010
PCMan
Re: How to replace master branch of a repo with that of ...
Thank you for the detailed answer! It's really useful. Now I fetch the new source code to a new branch. Later I plan to replace master with merge --ours when it's ready. Thanks --
Aug 6, 1:21 am 2010
Junio C Hamano
Re: Cooking of the ab/i18n series
Read it again---I didn't say "maintaining" a list at all; we are saying the same thing more or less ;-) You might need to massage the output from TRANSLATORS: comment to a more readable form suitable for inclusion in the documentation (depending on how that thing looks like), though. --
Aug 6, 8:48 am 2010
Junio C Hamano
Re: Cooking of the ab/i18n series
The "popular support" needs to be qualified. If you ask any random person "Is it a good thing if software package X supports i18n?", the answer would always be "yes"; popular support in that sense doesn't mean much. I am more worried about unintended consequence of this particular execution. For example, I would want to be absolutely sure that we won't break plumbing output in 'next' and the proposed mechanism helps others That is one good example. Perhaps we can get a list of messages ...
Aug 6, 6:30 am 2010
Ævar Arnfjörð Bjarmason
Re: Cooking of the ab/i18n series
I was thinking about support from the core contributors, which'd have I'm also worried about that, and I have some plans to deal with it after the merge. The first and most obvious one is that the list will be reviewing gettexizing patches as they go through. A patch which changes some plumbing format would be called out, but not one that just changes the UI messsage of e.g. "git init". There's also more that can be done, e.g. altering the test-lib.sh so that you can set an environment ...
Aug 6, 7:03 am 2010
Ævar Arnfjörð Bjarmason
Re: Cooking of the ab/i18n series
That's news to me. I'd assumed that it was mostly on track, i.e. that it would get merged down after cooking for a while in pu. However, if it's a matter of gathering popular support maybe I should change my strategy a bit. Perhaps it would help if I sent the entire series as it is in pu now to the list along with a cover letter explaining the main implications of merging it? All the RFCs so far have either focused on discussing the idea without the implementation, or small parts of the ...
Aug 6, 5:33 am 2010
Ævar Arnfjörð Bjarmason
Re: Cooking of the ab/i18n series
Ah yes. I didn't read it carefully enough. Yeah, if we're just talking about autogeneration it isn't hard to get a list of all translatable strings into a single ASCIIDOC page. I plan to write some translator documentation once this gets in and we start having people submit translations. E.g. a document that lists some of the core Git concepts that the translator will need to translate (e.g. "pull", "push", "commit", "tree", "object" etc.). --
Aug 6, 10:01 am 2010
Ævar Arnfjörð Bjarmason
Re: Cooking of the ab/i18n series
I don't mean to bombard you with E-Mails, but hopefully this one is a bit more to the point. As I'm sure you've gathered by now I'm keen to get this into Git. I'm also fully prepared to address any specific concerns about the series before it gets merged. However, and maybe I'm just dense, I can't really see some unambiguous things about the series that I could improve from your comments. So let's try to clear them up, shall we? My mental plan for this series has basically been as ...
Aug 6, 12:28 pm 2010
Junio C Hamano
Re: Cooking of the ab/i18n series
Matches my expectations modulo s/master/next/. The stuff parked in 'pu' was primarily because most of the work to get to this point was done during the pre-release freeze for 1.7.2 and I didn't want to get That's not 'main'. 'Breaking plumbing' is merely an example of a larger 'main concern' which is 'unintended consequences'. And please don't ask me to enumerate them exhaustively. By definition 'unintended consequences' cannot be enumerated. They are discovered over time either by ...
Aug 6, 4:01 pm 2010
René Scharfe
Re: BUG! missing .idx causes .pack to be removed
git-index-pack can rebuild the index for a pack file. Not sure if it should be done automagically, but the file is not completely useless. René --
Aug 6, 12:14 am 2010
Tay Ray Chuan
Re: BUG! missing .idx causes .pack to be removed
Hi, IIRC, a .pack file is useless without its corresponding .idx file. So the removal of a .pack file makes sense here - to me, at least. -- Cheers, Ray Chuan --
Aug 5, 8:24 pm 2010
Bo Yang
Re: [PATCH v4 11/18] Add tests for line history browser
So, should I write the above into the commit message? -- Regards! Bo ---------------------------- My blog: http://blog.morebits.org Why Git: http://www.whygitisbetterthanx.com/ --
Aug 5, 10:28 pm 2010
Thomas Rast
Re: [PATCH v4 11/18] Add tests for line history browser
You can just write it after the ---, since it ceases to be relevant after the email has been turned into a commit. -- Thomas Rast trast@{inf,student}.ethz.ch --
Aug 6, 2:04 am 2010
Junio C Hamano
Re: [PATCH v4 03/18] Add the basic data structure for li ...
Hmm... I do not see anything you added to this header file that needs such a forward declaration. Other files you added that include diffcore.h Isn't "range" too generic a term? Unless you make this as a static declaration only visible to functions where "range" can only mean "line ranges" in their context, that is. --
Aug 6, 12:42 pm 2010
Junio C Hamano
Re: [PATCH v4 05/18] Parse the -L options
Do these have to be static? cmd_log_init() may be near the top of the call chain and has less reason to be reentrant, but it feels somewhat Please do not call it "pathspec", as this is a specific path in a commit. Hmm, so the strategy is that you first run the command line through a pass of parse-options that is aware only of "-L" syntax, eat whatever it recognizes, and give remainder to the setup_revisions(). While I agree with that strategy in general, I think this implementation is ...
Aug 6, 12:42 pm 2010
Jonathan Nieder
Re: [PATCH v2] test-lib: user-friendly alternatives to t ...
When I first read this, I thought you were saying these helpers already existed. This is where the rationale goes, anyway, so maybe: Add new test_file_must_not_exist et al helpers for use by tests to more loudly diagnose failures that manifest themselves by the existence or nonexistence of a file or directory. So now you can use test_file_must_exist foo "so there" from your test, and when it fails due to foo being absent or being a symlink instead, instead of silence you ...
Aug 6, 3:57 pm 2010
Junio C Hamano
Re: jk/tag-contains: stalled
After thinking about this a bit more, I changed my mind. I think depth-first traversal from all tag tips, without running any traversal from the wanted commit, has a serious downside. What happens when you run "git tag --contains master" in a Linus tree after a major release but before he tags the -rc1 and closes the merge window? Doesn't the algorithm run all the way down to the root, only to say nothing? Admittedly the traversal will visit each commit once (starting from v2.6.12 down to ...
Aug 5, 10:44 pm 2010
Eugene Sajine
Re: git merge - "both added" conflict resolution
When i experimenting with it with test repos - it is working OK. So, i believe it will be very difficult to reproduce. I'm still having this problem with two repos of mine, but as it is not common, i gotta dig deeper there. Thanks, Eugene --
Aug 6, 7:57 am 2010
Pat Thoyts
Re: [PATCH] git-gui: Use shell to launch textconv filter ...
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes: OK compatibility with 'git blame' is a valid reason to do it your way. Tcl's exec (or open| is equivalent) doesn't go via shell. I'll check this on windows and apply it. Thanks. -- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD --
Aug 6, 10:56 am 2010
Matthieu Moy
Re: [PATCH] git-gui: Use shell to launch textconv filter ...
I'm not very fluent in Tcl, but I don't think this runs the command through a shell (pstree agrees with me). That will work in most cases, so that may be acceptable, but if you want to have full compatibility with what "git blame" does (by using a shell) and allow e.g. textconv = LANG=C some-command or textconv = cd ../; do-whatever which are already managed by "git blame" and are OK with my version, it's not going to do it. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ --
Aug 6, 1:51 am 2010
Daniel Johnson
[PATCH] Documentation: changes in the behavior of tagopt
--- How does this look? Documentation/config.txt | 4 +++- Documentation/fetch-options.txt | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index f81fb91..682ebef 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -1627,7 +1627,9 @@ remote.<name>.tagopt:: Setting this value to \--no-tags disables automatic tag following when fetching from remote <name>. Setting it to ...
Aug 6, 6:54 am 2010
Jakub Narebski
Re: Git server eats all memory
Nitpick: git-for-each-ref has `--format' option, no need for `cut'. -- Jakub Narebski Poland ShadeHawk on #git --
Aug 6, 4:34 am 2010
Nguyen Thai Ngoc Duy
Re: Git server eats all memory
Naah, git pack-objects needs list of commit tips. Try git for-each-ref|cut -c 1-40|git pack-objects --all --stdout > /dev/null -- Duy --
Aug 5, 6:51 pm 2010
Nguyen Thai Ngoc Duy
Re: Git server eats all memory
On Thu, Aug 5, 2010 at 4:33 PM, Ivan Kanis Try "git pack-objects --all --stdout > /dev/null" on the repo on server to see if it uses the same amount of memory you saw in cloning. You can then try debugging that command if it does. -- Duy --
Aug 5, 6:37 pm 2010
Ivan Kanis
Re: Git server eats all memory
Hello Jared and Nguyen, Thank you Nguyen for your command. I can now reproduce the problem without needing the network. I have been following Jared lead today on a potential memory leak. Here is what I found out. I downloaded the latest release of git 1.7.2.1 and compiled it with debugging support. I ran valgrind on the command and found two memory leaks. I put the output at the bottom of the e-mail as it's not very interesting. I patched one of the leak in pack_objects.c but got ...
Aug 6, 10:23 am 2010
Miles Bader
Re: [RFC] struct *_struct
There is a practical issue in that "struct foo *" can be used with just a forward declaration (or no declaration at all), whereas "foo *" requires the declaration of foo be visible. This is especially handy given C's use of #include, because in cases where there are circular type references, it can be very annoying to get things #included in the right order; being able to use a forward declaration instead of #include makes it easy to break such loops. One can still use "struct foo *" even if ...
Aug 5, 7:28 pm 2010
Michael Witten
Re: [RFC] struct *_struct
Those are valid points, but I'm not sure they have a practical basis; your problems are largely solved by capitalization conventions (which essentially provide shorter replacements for `struct '): typedef struct { /* ... */ } Foo; Foo foo; Unfortunately, such conventions don't enjoy the benefit of semantic protection. However, language-aware source navigation tools (like ctags) should be able to solve that problem and are probably more efficient in navigation time than ...
Aug 5, 8:57 pm 2010
Jared Hance
Re: [RFC] struct *_struct
I agree, thats much better. The original hate was on "struct foo foo". For some reason, I still prefer the version without the typedef, I agree here too. By the way, my comments were mostly against specifically "typedef foo struct foo", since that what was specifically mentioned. --
Aug 6, 5:29 am 2010
=?UTF-8?q?=C3=86var= ...
[PATCH v2] tests: A SANITY test prereq for testing if we ...
Some tests depend on not being able to write to files after chmod -w. This doesn't work when running the tests as root. Change test-lib.sh to test if this works, and if so it sets a new SANITY test prerequisite. The tests that use this previously failed when run under root. There was already a test for this in t3600-rm.sh, added by Junio C Hamano in 2283645 in 2006. That check now uses the new SANITY prerequisite. Some of this was resurrected from the "Tests in Cygwin" thread in ...
Aug 6, 3:09 pm 2010
Jakub Narebski
Re: Back-dating commits--way back--for constitution.git
We can *store* it without problems, the problem is with *interpretation* by porcelain (and some plumbing). -- Jakub Narebski Poland ShadeHawk on #git --
Aug 6, 1:18 am 2010
Ævar Arnfjörð Bjarmason
Re: Back-dating commits--way back--for constitution.git
32bit says: error in commit 826a4f7721fe1c3963a733ecbc5422f05925af5d: invalid author/committer line 64 bit doesn't give any warning at all. --
Aug 6, 8:19 am 2010
Brandon Casey
Re: Back-dating commits--way back--for constitution.git
Something other than the fact that -0400 should be -0500? Or are you talking about an issue with the software you are using to create the dates? -brandon --
Aug 6, 9:44 am 2010
Joel C. Salomon
Re: Back-dating commits--way back--for constitution.git
On Fri, Aug 6, 2010 at 11:19 AM, Ævar Arnfjörð Bjarmason Meanwhile, on Fri, Aug 6, 2010 at 11:08 AM, Sverre Rabbelier Seems the error can be checked for when you ask, but I'd rather not have git complain every time I use constitution.git. Aside: I generated the time stamps with <http://github.com/schwern/y2038>, which may be useful for cross-platform y2038 fixes. --Joel --
Aug 6, 8:29 am 2010
Michael Witten
Re: Back-dating commits--way back--for constitution.git
The problem is that git was written with leaky abstractions. --
Aug 6, 7:01 am 2010
Sverre Rabbelier
Re: Back-dating commits--way back--for constitution.git
Heya, That's what I mean though, if the porcelain notices it's trying to read in a date it can't interpret correctly it should warn the user of this fact. -- Cheers, Sverre Rabbelier --
Aug 6, 8:08 am 2010
Ævar Arnfjörð Bjarmason
Re: Back-dating commits--way back--for constitution.git
On Fri, Aug 6, 2010 at 16:00, Brandon Casey --
Aug 6, 9:50 am 2010
Brandon Casey
Re: Back-dating commits--way back--for constitution.git
I don't think you're using the latest git. I get this on 64 bit: error in commit 826a4f7721fe1c3963a733ecbc5422f05925af5d: invalid author/committer line - bad date This is triggered by the negative sign '-' in front of the time field which is not one of 0123456789. See fsck.c line 244. -brandon --
Aug 6, 9:00 am 2010
Joel C. Salomon
Re: Back-dating commits--way back--for constitution.git
On Thu, Aug 5, 2010 at 5:58 PM, Ævar Arnfjörð Bjarmason Cool, it works! (The 13:00 should have been 12:00, but there's some DST weirdness at work.) Can you check what git-fsck has to say about the repos, on 32- & 64-bit machines? --Joel --
Aug 6, 8:18 am 2010
Johannes Sixt
Re: [PATCH] bash-completion: Print a useful error when c ...
Any shell that does not support the <() syntax will have exited at this time with a syntax error and never get to print something. This could work: -- Hannes --
Aug 6, 2:31 pm 2010
Johannes Sixt
Re: [PATCH] rebase -i: add exec command to launch a shel ...
What happens if the command modifies the worktree and/or the index? -- Hannes --
Aug 6, 2:07 pm 2010
Ralf Ebert
Re: [PATCH v2] Do not unquote + into ' ' in URLs
url_decode seems to be called only from connect.c to support percent-encoding for git/ssh-URLs, so at least as of now, there should be no problem here. Since applying the patch, git clone 'git://git.gnome.org/gtk+' works ok again for me. Greetings, Ralf --
Aug 6, 3:46 am 2010
Jonathan Nieder
Re: [PATCH svnrdump-standalone] Sync with upstream
Most of this patch is Subversion code. The rest, which is my own doing, I place in the public domain. You may freely use, modify, distribute, and relicense it. .gitignore | 5 + Makefile | 35 +++ dump_editor.c | 9 +- svn17_compat.c | 842 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ svn17_compat.h | 179 ++++++++++++ svnrdump.c | 5 +- svntest/main.py | 17 +- 7 files changed, 1076 insertions(+), 16 deletions(-) create mode 100644 ...
Aug 6, 11:37 am 2010
Jonathan Nieder
[PATCH 08/12] config: run setup_git_directory_gently() sooner
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> For the pager choice (and the choice to paginate) to reflect the current repository configuration, the repository needs to be located first. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- Relative to the previous round, this simplifies the patch by retaining the nongit var; squashes in a test; and adds some words of explanation to ...
Aug 5, 8:15 pm 2010
Junio C Hamano Aug 6, 12:42 pm 2010
Jonathan Nieder
[PATCH jn/paginate-fix 0/12] Re: git --paginate: do not ...
Let’s help some of them out a little. These patches teach a few more built-ins to do something like RUN_SETUP; more precisely, a RUN_SETUP_GENTLY facility is introduced to run setup_git_directory_gently() early just like NEEDS_PREFIX has always caused setup_git_directory() to be run early. This series wouldn’t be possible without Duy’s recent efforts to roll out other fixes from the famous nd/setup topic --- thanks! The patches should be familiar[1] and I think they are better justified ...
Aug 5, 7:35 pm 2010
Jonathan Nieder
[PATCH 04/12] shortlog: run setup_git_directory_gently() ...
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> shortlog already runs a repository search unconditionally; running such a search earlier is not very risky. Without this change, the “[pager] shortlog” configuration is not respected at all: “git shortlog” unconditionally paginates. The tests are a bit slow. Running the full battery like this for all built-in commands would be counterproductive; the intent is rather to test shortlog as a representative example command ...
Aug 5, 8:01 pm 2010
Jonathan Nieder
[PATCH 09/12] index-pack: run setup_git_directory_gently ...
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> index-pack already runs a repository search unconditionally; running such a search earlier is not risky and ensures GIT_DIR will be set correctly if the configuration needs to be accessed from run_builtin(). Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- Requires the jn/maint-setup-fix topic to apply. See the cover letter "[PATCH ...
Aug 5, 8:18 pm 2010
Jonathan Nieder
[PATCH 10/12] ls-remote: run setup_git_directory_gently( ...
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> ls-remote already runs a repository search unconditionally to learn about remote nicknames and "[url] insteadof" shortcuts. Run that search a little sooner, and now one can try [pager] ls-remote to automatically paginate ls-remote output, or use repository-local [core] pager = whatever with "git --paginate ls-remote <url>". Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano ...
Aug 5, 8:20 pm 2010
Jonathan Nieder
[PATCH 2/2] Allow "check-ref-format --branch" from subdi ...
check-ref-format --branch requires access to the repository to resolve refs like @{-1}. Noticed by Duy. Cc: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- The original used the RUN_SETUP_GENTLY flag to run setup unconditionally. That might still be a good idea, but I am more comfortable running setup just for this subcommand for now so commands like "git check-ref-format refs/foo" are not affected. builtin/check-ref-format.c | 2 ...
Aug 5, 8:39 pm 2010
Jonathan Nieder
[PATCH 05/12] grep: run setup_git_directory_gently() sooner
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> git grep already runs a repository search unconditionally, even when the --no-index option is supplied; running such a search earlier is not very risky. Just like with shortlog, without this change, the “[pager] grep” configuration is not respected at all. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- Aside from rewriting the ...
Aug 5, 8:06 pm 2010
Jonathan Nieder
[PATCH 07/12] bundle: run setup_git_directory_gently() sooner
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Without this change, “git -p bundle” does not always respect the repository-local “[core] pager” setting. It is hard to notice because subcommands other than “git bundle unbundle” do not produce much output. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- New tests and explanation. The first new test perhaps deserves some ...
Aug 5, 8:12 pm 2010
Jonathan Nieder
[PATCH master 0/2] fix "check-ref-format --branch" from ...
Here’s a quick fix from the nd/setup series. Tested against master, though it probably should be against maint. Jonathan Nieder (2): check-ref-format: split off functions for subcommands check-ref-format --branch: run repository search builtin/check-ref-format.c | 44 ++++++++++++++++++++++++++---------------- t/t1402-check-ref-format.sh | 17 ++++++++++++++++ 2 files changed, 44 insertions(+), 17 deletions(-) --
Aug 5, 8:34 pm 2010
Jonathan Nieder
[PATCH 12/12] merge-file: run setup_git_directory_gently ...
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Part of a campaign to make repository-local configuration available early (simplifying the startup sequence for built-in commands). Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- As before (except the commit message). Well, that’s it. There’s also a separate fix for "check-ref-format --branch", which I’ll send under ...
Aug 5, 8:27 pm 2010
Jonathan Nieder
[PATCH 1/2] check-ref-format: handle subcommands in sepa ...
The code for each subcommand should be easier to read and manipulate this way. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- builtin/check-ref-format.c | 42 +++++++++++++++++++++++++----------------- 1 files changed, 25 insertions(+), 17 deletions(-) diff --git a/builtin/check-ref-format.c b/builtin/check-ref-format.c index b106c65..8707ee9 100644 --- a/builtin/check-ref-format.c +++ b/builtin/check-ref-format.c @@ -33,28 +33,36 @@ static void collapse_slashes(char *dst, ...
Aug 5, 8:36 pm 2010
Nguyen Thai Ngoc Duy
Re: [PATCH jn/paginate-fix 0/12] Re: git --paginate: do ...
I was waiting for jn/maint-setup-fix to graduate before pushing out some more patches then I got side tracked by the subtree clone. Anyway, thanks! -- Duy --
Aug 5, 9:26 pm 2010
Jonathan Nieder
[PATCH 03/12] git wrapper: allow setup_git_directory_gen ...
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> In the spirit of v1.4.2-rc3~34^2^2 (Call setup_git_directory() much earlier, 2006-07-28), let run_builtin() take care of searching for a repository for built-ins that want to make use of one if present. So now you can mark your command with RUN_SETUP_GENTLY and use nongit = !startup_info->have_repository; in place of prefix = setup_git_directory_gently(&nongit); and everything will be the same, except the repository is discovered a ...
Aug 5, 7:52 pm 2010
Jonathan Nieder
[PATCH 06/12] apply: run setup_git_directory_gently() sooner
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> As v1.7.2~16^2 (2010-07-14) explains, without this change, “git --paginate apply” can ignore the repository-local “[core] pager” configuration. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- New explanation and test; simplified patch by keeping the is_not_gitdir local. builtin/apply.c | 3 +-- git.c | 2 +- ...
Aug 5, 8:08 pm 2010
Jonathan Nieder
[PATCH 11/12] var: run setup_git_directory_gently() sooner
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Part of a campaign to make repository-local configuration available early (simplifying the startup sequence for built-in commands). Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- snuck in a little vertical compression while at it ;-) builtin/var.c | 9 ++------- git.c | 2 +- 2 files changed, 3 insertions(+), 8 ...
Aug 5, 8:21 pm 2010
Jonathan Nieder
[PATCH 01/12] git wrapper: introduce startup_info struct
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> The startup_info struct will collect information managed by the git setup code, such as the prefix for relative paths passed on the command line (i.e., path to the starting cwd from the toplevel of the work tree) and whether a git repository has been found. In other words, startup_info is intended to be a collection of global variables with results that were previously returned from setup functions. This state is global anyway (since the cwd ...
Aug 5, 7:40 pm 2010
Jonathan Nieder
[PATCH 02/12] setup: remember whether repository was found
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> As v1.7.2~16^2 (git --paginate: paginate external commands again, 2010-07-14) explains, builtins (like git config) that do not use RUN_SETUP are not finding GIT_DIR set correctly when it is time to launch the pager from run_builtin(). If they were to search for a repository sooner, then the outcome of such early repository accesses would be more predictable and reliable. The cmd_*() functions learn whether a repository was found through ...
Aug 5, 7:46 pm 2010
Conrad Parker
Re: RFD: git-bzr: anyone interested?
Hi, Anyone interested in git-bzr might also want to look at some recent rewrites; from the current git-bzr README: The following are rewrites in Python and may offer better bzr integration: * http://github.com/termie/git-bzr-ng * http://github.com/matthew-brett/git-bzr (... and I'd also be interested to know how well either of these work :) cheers, Conrad (kfish). --
Aug 6, 12:19 am 2010
previous daytodaynext day
August 5, 2010August 6, 2010August 7, 2010