[PATCH 5/5] log: parse separate option for --glob

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Matthieu Moy
Date: Thursday, August 5, 2010 - 1:22 am

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 revision.c               |    7 +++++--
 t/t6018-rev-list-glob.sh |    6 ++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/revision.c b/revision.c
index 489a3c2..f241f34 100644
--- a/revision.c
+++ b/revision.c
@@ -1484,6 +1484,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
 {
 	int i, flags, left, seen_dashdash, read_from_stdin, got_rev_arg = 0;
 	const char **prune_data = NULL;
+	const char *optarg;
+	int argcount;
 
 	/* First, search for "--" */
 	seen_dashdash = 0;
@@ -1530,10 +1532,11 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
 				handle_refs(revs, flags, for_each_remote_ref);
 				continue;
 			}
-			if (!prefixcmp(arg, "--glob=")) {
+			if ((argcount = parse_long_opt("glob", argv + i, &optarg))) {
 				struct all_refs_cb cb;
+				i += argcount - 1;
 				init_all_refs_cb(&cb, revs, flags);
-				for_each_glob_ref(handle_one_ref, arg + 7, &cb);
+				for_each_glob_ref(handle_one_ref, optarg, &cb);
 				continue;
 			}
 			if (!prefixcmp(arg, "--branches=")) {
diff --git a/t/t6018-rev-list-glob.sh b/t/t6018-rev-list-glob.sh
index 58428d9..fb8291c 100755
--- a/t/t6018-rev-list-glob.sh
+++ b/t/t6018-rev-list-glob.sh
@@ -123,6 +123,12 @@ test_expect_success 'rev-list --glob=refs/heads/subspace/*' '
 
 '
 
+test_expect_success 'rev-list --glob refs/heads/subspace/*' '
+
+	compare rev-list "subspace/one subspace/two" "--glob refs/heads/subspace/*"
+
+'
+
 test_expect_success 'rev-list --glob=heads/subspace/*' '
 
 	compare rev-list "subspace/one subspace/two" "--glob=heads/subspace/*"
-- 
1.7.2.1.30.g18195

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
What's cooking in git.git (Aug 2010, #01; Wed, 4), Junio C Hamano, (Wed Aug 4, 3:24 pm)
jk/tag-contains: stalled, Ted Ts'o, (Wed Aug 4, 5:16 pm)
tc/checkout-B, Jonathan Nieder, (Wed Aug 4, 11:53 pm)
Re: What's cooking in git.git (Aug 2010, #01; Wed, 4), Matthieu Moy, (Thu Aug 5, 1:20 am)
[PATCH 1/5] diff: parse separate options like -S foo, Matthieu Moy, (Thu Aug 5, 1:22 am)
[PATCH 5/5] log: parse separate option for --glob, Matthieu Moy, (Thu Aug 5, 1:22 am)
Re: tc/checkout-B, Tay Ray Chuan, (Thu Aug 5, 3:18 am)
mm/shortopt-detached, Jonathan Nieder, (Thu Aug 5, 4:41 am)
Re: [PATCH 1/5] diff: parse separate options like -S foo, Jakub Narebski, (Thu Aug 5, 5:16 am)
Re: jk/tag-contains: stalled, Junio C Hamano, (Thu Aug 5, 9:29 am)
Re: jk/tag-contains: stalled, Junio C Hamano, (Thu Aug 5, 10:05 am)
Re: jk/tag-contains: stalled, Jeff King, (Thu Aug 5, 10:36 am)
Re: jk/tag-contains: stalled, Junio C Hamano, (Thu Aug 5, 11:47 am)
Re: jk/tag-contains: stalled, Jeff King, (Thu Aug 5, 12:06 pm)
Re: jk/tag-contains: stalled, Jay Soffian, (Thu Aug 5, 12:18 pm)
Re: jk/tag-contains: stalled, Jeff King, (Thu Aug 5, 12:27 pm)
Re: jk/tag-contains: stalled, Jay Soffian, (Thu Aug 5, 1:00 pm)
Re: jk/tag-contains: stalled, Ted Ts'o, (Thu Aug 5, 1:36 pm)
Re: jk/tag-contains: stalled, Junio C Hamano, (Thu Aug 5, 1:53 pm)
Re: jc/sha1-name-find-fix, Dmitry V. Levin, (Thu Aug 5, 2:12 pm)
Re: jk/tag-contains: stalled, Thomas Rast, (Thu Aug 5, 2:38 pm)
Re: jk/tag-contains: stalled, Junio C Hamano, (Thu Aug 5, 3:15 pm)
Re: jk/tag-contains: stalled, Junio C Hamano, (Thu Aug 5, 10:44 pm)