Ramkumar Ramachandra wrote:

quoted text
> From: David Barr <david.barr@cordelta.com>
> 
> This library provides thread-unsafe fgets()- and fread()-like
> functions where the caller does not have to supply a buffer.  It
> maintains a couple of static buffers and provides an API to use
> them.
> 
> NEEDSWORK: what should buffer_copy_bytes do on error?

For consistency with the rest of vcs-svn, it should do nothing. :)

I would love to see svn-fe diagnosing and recovering somehow from
faulty input.  For now it follows the easier route of just ignoring
(and skipping) confusing input.

Probably this should be mentioned in the man page somewhere.

[...]
quoted text
> +void buffer_copy_bytes(uint32_t len)
> +{
[...]
quoted text
> +		if (ferror(infile) || ferror(stdout))
> +			/* NEEDSWORK: handle error. */

The next input/output operation will fail, causing svn-fe to quit
early, so it would not be easy for such an error to go unnoticed.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html