On Fri, May 14, 2010 at 08:54:07AM +0200, Knittl wrote:

quoted text
> > That being said, I still get "Initial commit on master". I think that
> > stat_tracking_branch just gives up if the branch doesn't exist (which
> > does make some sense). So in practice, I think your original and this
> > one actually behave the same (sorry, I know that changing it was my
> > suggestion).
> 
> yep, that's what i discovered too—but i don't care if this condition
> is 3 lines up or down. if stat_tracking_branch decides it will work
> for initial commits, then this code will do the expected thing

Agreed.

quoted text
> should be no problem. the second patch changed quite a bit, so i
> thought it is easier to review when i send it as a separate patch. the
> final patch can be squashed of course

OK.  Nobody else seems to be commenting, so I would go ahead and put
together your final patch, cc-ing the maintainer.

quoted text
> >  2. Your patch has wrapped lines which make it impossible to apply
> >     without fixing up manually. This is a common gmail problem.  See
> >     the "gmail" section of SubmittingPatches.
> 
> ok, browsed through that. i think i will just put my branch into a
> pasteservice or on a fileserver, unless the email way is *really*
> preferred—what about email attachments?

Inline email is best, but I think an email attachment would be preferred
to putting it on some out-of-band service (it's nice for the mailing
list archive to have a record of everything).

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html