[PATCH 0/2] fix weird git --paginate behavior

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jonathan Nieder
Date: Monday, April 5, 2010 - 9:01 pm

Hi,

Nguyễn Thái Ngọc Duy wrote:


Thanks for posting this series.  I had not read it in full before.

The series is very long and it is hard to make certain it does not
introduce regressions.  Here is my idea for working around this: the
idea is to grab patches from the series to form short, independently
justifiable mini-series.  Once most of the functional changes are
merged, it should be a lot easier to evaluate the core code change
that makes setup more brittle (which I like a lot).

What do you think?  Is it worth the trouble?

Here’s an example mini-series.  Patch 1 adds a test case for
some weird git -p behavior.  Patch 2 fixes it.

Jonathan Nieder (1):
  t7006: test an edge case for git --paginate

Nguyễn Thái Ngọc Duy (1):
  builtins: do not commit pager choice early

 git.c            |    1 -
 t/t7006-pager.sh |   32 ++++++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 1 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/43] nd/setup update, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 01/43] builtin: introduce startup_info struct, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 02/43] builtin: Support RUN_SETUP_GENTLY to set up ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 03/43] config: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 04/43] hash-object: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 05/43] shortlog: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 06/43] grep: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 07/43] builtin: USE_PAGER should not be used withou ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 08/43] archive: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 09/43] mailinfo: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 10/43] check-ref-format: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 11/43] verify-pack: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 12/43] apply: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 13/43] bundle: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 14/43] diff: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:40 am)
[PATCH 15/43] help: take note why this command is not appl ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 16/43] ls-remote: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 17/43] var: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 18/43] merge-file: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 19/43] worktree setup: calculate prefix even if no ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 20/43] index-pack: trust the prefix returned by set ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 21/43] index-pack: use RUN_SETUP_GENTLY, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 22/43] Move enter_repo() to setup.c, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 23/43] enter_repo(): initialize other variables as ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 24/43] rev-parse --git-dir: print relative gitdir c ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 25/43] worktree setup: call set_git_dir explicitly, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 26/43] Add git_config_early(), =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 27/43] Use git_config_early() instead of git_config ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 28/43] worktree setup: restore original state when ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 29/43] init/clone: turn on startup->have_repository ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 30/43] git_config(): do not read .git/config if the ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 31/43] Do not read .git/info/exclude if there is no ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 32/43] Do not read .git/info/attributes if there is ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 33/43] apply: do not check sha1 if there is no repo ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 34/43] config: do not read .git/config if there is ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 35/43] run_builtin(): save "-h" detection result fo ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 36/43] builtins: utilize startup_info->help where p ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 37/43] builtins: check for startup_info->help, prin ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 38/43] Allow to undo setup_git_directory_gently() g ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 39/43] alias: keep repository found while collectin ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 40/43] Guard unallowed access to repository when it ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 41/43] t0001: Add test cases for "git init" with al ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 42/43] builtins: setup repository before print unkn ..., =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 43/43] builtins: do not commit pager choice early, =?UTF-8?q?Nguy=E1=BB ..., (Mon Apr 5, 11:41 am)
[PATCH 0/2] fix weird git --paginate behavior, Jonathan Nieder, (Mon Apr 5, 9:01 pm)
[PATCH 2/2] builtins: do not commit pager choice early, Jonathan Nieder, (Mon Apr 5, 9:06 pm)
Re: [PATCH 2/2] builtins: do not commit pager choice early, Jonathan Nieder, (Mon Apr 5, 9:16 pm)
Re: [PATCH 0/2] fix weird git --paginate behavior, Nguyen Thai Ngoc Duy, (Tue Apr 6, 12:00 am)
Re: [PATCH 0/2] fix weird git --paginate behavior, Junio C Hamano, (Tue Apr 6, 12:17 am)