Re: 'commit -a' safety

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Saturday, April 24, 2010 - 6:13 pm

Petr Baudis <pasky@suse.cz> writes:


I am somewhat torn.

I have made mistake of running "commit -a" after I spent time sifting my
changes in the work tree.  I can see that I would have been helped by it
if the safety were there.

But at the same time, I also know that my development is often a cycle of
change then diff then add (to mark the part I am happy with), and when I
am happy with the output from diff, I conclude it with "commit -a" to
conclude the whole thing.  I can see that I would be irritated to if that
final step failed.

But I suspect the irritation would be relatively mild: "ah, these days I
shouldn't use 'commig -a' to conclude these incremental change-review-add
cycle; instead, I should say 'add -u' then 'commit'".

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Please default to 'commit -a' when no changes were added, Jonathan Nieder, (Thu Apr 22, 8:58 am)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Thu Apr 22, 11:37 am)
Re: Please default to 'commit -a' when no changes were added, Sverre Rabbelier, (Thu Apr 22, 12:08 pm)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Thu Apr 22, 1:37 pm)
Re: Please default to 'commit -a' when no changes were added, Jonathan Nieder, (Thu Apr 22, 3:27 pm)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Fri Apr 23, 2:03 am)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Fri Apr 23, 2:09 am)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Fri Apr 23, 2:14 am)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Fri Apr 23, 2:15 am)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Fri Apr 23, 2:25 am)
Re: Please default to 'commit -a' when no changes were added, Björn Steinbrink, (Fri Apr 23, 2:39 am)
Re: Please default to 'commit -a' when no changes were added, Sverre Rabbelier, (Fri Apr 23, 4:57 am)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Fri Apr 23, 7:23 am)
Re: Please default to 'commit -a' when no changes were added, Wincent Colaiuta, (Fri Apr 23, 9:01 am)
Re: Please default to 'commit -a' when no changes were added, Michael Witten, (Fri Apr 23, 10:00 am)
Re: Please default to 'commit -a' when no changes were added, Matthias Andree, (Fri Apr 23, 11:59 am)
Re: Please default to 'commit -a' when no changes were added, Michael Witten, (Fri Apr 23, 12:34 pm)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Fri Apr 23, 1:17 pm)
Re: Please default to 'commit -a' when no changes were added, Matthias Andree, (Fri Apr 23, 3:18 pm)
Re: Please default to 'commit -a' when no changes were added, Matthias Andree, (Fri Apr 23, 3:35 pm)
Re: 'commit -a' safety, Miles Bader, (Sat Apr 24, 2:56 am)
Re: 'commit -a' safety, Andreas Schwab, (Sat Apr 24, 3:05 am)
Re: 'commit -a' safety, Jakub Narebski, (Sat Apr 24, 3:26 am)
Re: 'commit -a' safety, Jakub Narebski, (Sat Apr 24, 4:48 am)
Re: 'commit -a' safety, Miles Bader, (Sat Apr 24, 6:29 am)
Re: 'commit -a' safety, Joey Hess, (Sat Apr 24, 7:28 am)
Re: 'commit -a' safety, Mike Hommey, (Sat Apr 24, 8:11 am)
Re: 'commit -a' safety, Nicolas Pitre, (Sat Apr 24, 11:23 am)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Sat Apr 24, 2:15 pm)
Re: Please default to 'commit -a' when no changes were added, Jonathan Nieder, (Sat Apr 24, 2:40 pm)
Re: Please default to 'commit -a' when no changes were added, Goswin von Brederlow, (Sat Apr 24, 3:08 pm)
Re: Please default to 'commit -a' when no changes were added, Jonathan Nieder, (Sat Apr 24, 3:42 pm)
Re: 'commit -a' safety, Jakub Narebski, (Sat Apr 24, 4:47 pm)
Re: 'commit -a' safety, Jakub Narebski, (Sat Apr 24, 5:16 pm)
Re: 'commit -a' safety, Junio C Hamano, (Sat Apr 24, 6:13 pm)
Re: 'commit -a' safety, Miles Bader, (Sat Apr 24, 7:43 pm)
Re: Please default to 'commit -a' when no changes were added, Jonathan Nieder, (Sat Apr 24, 8:33 pm)
Re: 'commit -a' safety, Jakub Narebski, (Sun Apr 25, 1:01 am)