Re: [PATCH] fast-import docs: LT is valid in email, GT is not

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jonathan Nieder
Date: Saturday, April 24, 2010 - 9:12 am

Hi Mark,

Mark Lodato wrote:


	Here <name> is the person’s display name (for example
	“Com M Itter”)

So the original text is correct --- a <name> cannot contain LT because
a less-than sign marks the boundary between a name and email address.

Maybe you were wondering what characters are valid in an e-mail address?
The comments in fast-import.c and code in ident.c are consistent about
this: the forbidden characters are <, >, and LF, though no one seems to
check (see also my other reply).  A patch to explain this (including a
reference to git-commit-tree(1), I guess) might be useful.

git won’t understand an email with embedded > or LF.  I’m not sure a <
would cause problems, but I don’t mind that it is disallowed.

Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] fsck: check ident lines in commit objects, Jonathan Nieder, (Sat Apr 24, 9:06 am)
Re: [PATCH] fast-import docs: LT is valid in email, GT is not, Jonathan Nieder, (Sat Apr 24, 9:12 am)
Re: [PATCH] fsck: check ident lines in commit objects, Jonathan Nieder, (Sat Apr 24, 9:59 am)
Re: [PATCH] fsck: check ident lines in commit objects, Shawn O. Pearce, (Sat Apr 24, 12:04 pm)
[PATCH 0/2] fast-import: tighten up parsing ident line, Jonathan Nieder, (Sat Apr 24, 1:38 pm)
[PATCH 2/2] fast-import: validate entire ident string, Jonathan Nieder, (Sat Apr 24, 2:10 pm)
Re: [PATCH 2/2] fast-import: validate entire ident string, Shawn O. Pearce, (Mon Apr 26, 9:02 am)
Re: [PATCH 2/2] fast-import: validate entire ident string, Jonathan Nieder, (Mon Apr 26, 9:24 am)
Re: [PATCH 2/2] fast-import: validate entire ident string, Jonathan Nieder, (Mon Apr 26, 9:30 am)
Re: [PATCH 2/2] fast-import: validate entire ident string, Junio C Hamano, (Tue May 4, 10:11 am)