[PATCH 1/2] t5704 (bundle): add tests for bundle --stdin

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jonathan Nieder
Date: Monday, April 19, 2010 - 1:03 am

As long as no rev-list arguments are supplied on the command line,
git bundle create --stdin currently segfaults.  With added rev-list
arguments, it does not segfault, but the revisions from stdin are
ignored.

Thanks to Joey Hess <joey@kitenet.net> for the report.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 t/t5704-bundle.sh |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/t/t5704-bundle.sh b/t/t5704-bundle.sh
index a8f4419..1154a4e 100755
--- a/t/t5704-bundle.sh
+++ b/t/t5704-bundle.sh
@@ -30,4 +30,20 @@ test_expect_success 'tags can be excluded by rev-list options' '
 
 '
 
+test_expect_failure 'bundle --stdin' '
+
+	echo master | git bundle create stdin-bundle.bdl --stdin &&
+	git ls-remote stdin-bundle.bdl > output &&
+	grep master output
+
+'
+
+test_expect_failure 'bundle --stdin <rev-list options>' '
+
+	echo master | git bundle create hybrid-bundle.bdl --stdin tag &&
+	git ls-remote hybrid-bundle.bdl > output &&
+	grep master output
+
+'
+
 test_done
-- 
1.7.1.rc1

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
bug: git-bundle create foo --stdin -&gt; segfault, Joey Hess, (Mon Jan 18, 5:26 pm)
Re: bug: git-bundle create foo --stdin -&gt; segfault, Johannes Schindelin, (Tue Jan 19, 4:52 pm)
[PATCH 1/2] t5704 (bundle): add tests for bundle --stdin, Jonathan Nieder, (Mon Apr 19, 1:03 am)
[PATCH 2/2] fix &quot;bundle --stdin&quot; segfault, Jonathan Nieder, (Mon Apr 19, 1:03 am)
[PATCH 2/8] bundle: use libified rev-list --boundary, Jonathan Nieder, (Fri Jun 25, 11:20 pm)
[PATCH 5/8] bundle: reuse setup_revisions result, Jonathan Nieder, (Fri Jun 25, 11:22 pm)
[PATCH 6/8] Fix bundle --stdin, Jonathan Nieder, (Fri Jun 25, 11:28 pm)
[PATCH 8/8] bundle_create: Do not exit when given no revs ..., Jonathan Nieder, (Fri Jun 25, 11:31 pm)
Re: [PATCH 2/8] bundle: use libified rev-list --boundary, Junio C Hamano, (Wed Jun 30, 10:57 am)
Re: [PATCH 2/8] bundle: use libified rev-list --boundary, Jonathan Nieder, (Wed Jun 30, 1:34 pm)