Home » Mailing list archives » git » 2010 » April » 15

Re: [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Chris Webb
Subject: Re: [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line
Date: Thursday, April 15, 2010 - 8:55 am

Thomas Rast <trast@student.ethz.ch> writes:


I hadn't but have now. I don't buy the idea that this date is an unused
placeholder in mbox files, and therefore can be sensibly set to an arbitary
constant date in the distant past.

RFC4155 appendix A defines this date as the date a message was received.
This isn't directly applicable to the context of format-patch, but other
users of mbox format (e.g. MUAs doing an fcc) tend to fill it with the date
the message was generated, and might reasonably expect to be able to
sort on this date, e.g. when displaying a drafts folder.

If nothing else, it's extremely surprising to run format-patch, see a
ridiculous date and wonder how your system time has become corrupted while
you've been working!

Cheers,

Chris.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] format-patch: use current date in mbox 'From COMMI ..., Chris Webb, (Thu Apr 15, 7:41 am)
Re: [PATCH] format-patch: use current date in mbox 'From C ..., Chris Webb, (Thu Apr 15, 8:16 am)
Re: [PATCH] format-patch: use current date in mbox 'From C ..., Thomas Rast, (Thu Apr 15, 8:35 am)
Re: [PATCH] format-patch: use current date in mbox 'From C ..., Chris Webb, (Thu Apr 15, 8:55 am)
Re: [PATCH] format-patch: use current date in mbox 'From C ..., Jonathan Nieder, (Thu Apr 15, 4:19 pm)
Re: [PATCH] format-patch: use current date in mbox 'From C ..., Chris Webb, (Fri Apr 16, 12:52 am)
[PATCH v2 1/2] format-patch: use commit date in mbox 'From ..., Chris Webb, (Fri Apr 16, 9:42 am)
[PATCH 2/2] Fix t4013 with commit date in mbox 'From COMMI ..., Chris Webb, (Fri Apr 16, 9:42 am)
Re: [PATCH 2/2] Fix t4013 with commit date in mbox 'From C ..., Santi Béjar, (Fri Apr 16, 10:59 am)
[PATCH v3] format-patch: use commit date in mbox 'From COM ..., Chris Webb, (Sat Apr 17, 1:01 am)
Re: [PATCH] format-patch: use current date in mbox 'From C ..., Junio C Hamano, (Sat Apr 17, 11:16 am)