On Tue, Apr 13, 2010 at 10:59:46AM +0200, Johannes Gilger wrote:

quoted text
> Thanks for the feedback Jeff. I've put your suggestions into my patch
> and tried to come up with a sensible name for 'userformat_fill_want'.
> As you can see I called it 'userformat_find_requirements', but am not
> really satisfied with it since it's too long and not quite to the
> point.
> 
> Anything else missing?

This version looks good to me.

Two minor comments:

quoted text
> -	if (!rev->show_notes_given && !rev->pretty_given)
> +	userformat_find_requirements(NULL,&w);

 1. Style, no whitespace between arguments.

 2. That function name also sucks. I doubt it is worth spending more
    time on, though.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html