Re: [PATCH] send-email: lazily assign editor variable

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jonathan Nieder
Date: Friday, March 26, 2010 - 2:45 pm

Junio C Hamano wrote:


With DISPLAY set, running “TERM=dumb vi | cat” with an appropriate
symlink in $PATH:

vim
	Prints “Vim: Warning: Output is not to a terminal” to stderr,
	waits about a second, then
	runs without clearing the screen, using ANSI escapes to move around.

elvis 1.4
	Prints “This termcap entry lacks the :up=: capability” to stderr,
	fails with status 1.

elvis 2 (more precisely, the elvisnox script from Debian)
	Prints “termcap needs up” to stderr,
	fails with status 1.

nvi
	Prints “ex/vi: Vi's standard input and output must be a terminal” to stderr,
	fails with status 1.

With TERM=dumb but standard output going straight to the terminal, the
situation is not very different for vim and elvis, while nvi gets
utterly confused (it only writes output to the bottom line for some
reason).

So I think it still makes sense to work around this bug in the vi clones.

HTH,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[REGRESSION] git var GIT_EDITOR fails without tty, Uwe =?iso-8859-1?Q?K ..., (Mon Mar 22, 7:59 am)
[PATCH] send-email: lazily assign editor variable, Michael J Gruber, (Mon Mar 22, 9:12 am)
Re: [PATCH] send-email: lazily assign editor variable, Uwe =?iso-8859-1?Q?K ..., (Mon Mar 22, 9:41 am)
[PATCH] send-email: do not check for editor until needed, Jonathan Nieder, (Mon Mar 22, 4:25 pm)
Re: [PATCH] send-email: lazily assign editor variable, Jonathan Nieder, (Mon Mar 22, 5:58 pm)
RE: [PATCH] send-email: do not check for editor until needed, Peter Kjellerstedt, (Tue Mar 23, 2:15 am)
Re: [PATCH] send-email: lazily assign editor variable, Michael J Gruber, (Tue Mar 23, 3:56 am)
Re: [PATCH] send-email: do not check for editor until needed, Jonathan Nieder, (Tue Mar 23, 12:25 pm)
Re: [PATCH] send-email: lazily assign editor variable, Junio C Hamano, (Wed Mar 24, 10:52 am)
Re: [PATCH] send-email: lazily assign editor variable, Jonathan Nieder, (Wed Mar 24, 10:17 pm)
Re: [PATCH] send-email: lazily assign editor variable, Michael J Gruber, (Thu Mar 25, 1:03 am)
Re: [PATCH] send-email: lazily assign editor variable, Junio C Hamano, (Fri Mar 26, 12:32 pm)
Re: [PATCH] send-email: lazily assign editor variable, Junio C Hamano, (Fri Mar 26, 12:32 pm)
Re: [PATCH] send-email: lazily assign editor variable, Jonathan Nieder, (Fri Mar 26, 2:45 pm)