Re: [PATCH] rev-list: heed --abbrev-commit option

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Friday, March 26, 2010 - 12:32 pm

Michael J Gruber <git@drmicha.warpmail.net> writes:


Hmm, I actually think this was deliberate.  rev-list is designed to be a
low level machinery for getting full object names, and in that context,
setting the default abbreviation length to "don't abbreviate" gave us some
safety, with additional safety of requiring a separate --abbrev-commit
option to affect the main "show the commit object names" codepath (the
latter of which would not likely to change).  The caller sets explicitly
how long an output it wants (see git-rebase--interactive for an example).

Having said that, I don't think this would break existing scripts, so
let's queue it and see what happens.



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git rev-list formatting, Eli Barzilay, (Mon Mar 22, 4:30 am)
Re: git rev-list formatting, Eli Barzilay, (Mon Mar 22, 4:39 am)
Re: git rev-list formatting, Michael J Gruber, (Mon Mar 22, 6:08 am)
[PATCH] rev-list: heed --abbrev-commit option, Michael J Gruber, (Mon Mar 22, 6:36 am)
Re: git rev-list formatting, Eli Barzilay, (Mon Mar 22, 7:42 am)
Re: git rev-list formatting, =?ISO-8859-1?Q?Ren=E ..., (Mon Mar 22, 10:22 am)
Re: git rev-list formatting, Eli Barzilay, (Mon Mar 22, 6:57 pm)
Re: git rev-list formatting, Michael J Gruber, (Tue Mar 23, 3:52 am)
Re: git rev-list formatting, Eli Barzilay, (Tue Mar 23, 4:06 am)
Re: git rev-list formatting, Jeff King, (Tue Mar 23, 5:26 am)
Re: git rev-list formatting, Erik Faye-Lund, (Tue Mar 23, 5:40 am)
Re: git rev-list formatting, Eli Barzilay, (Tue Mar 23, 5:59 am)
Re: [PATCH] rev-list: heed --abbrev-commit option, Junio C Hamano, (Fri Mar 26, 12:32 pm)
Re: [PATCH] rev-list: heed --abbrev-commit option, Michael J Gruber, (Sat Mar 27, 6:30 am)