Re: [PATCH 1/4] gitweb: notes feature

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johan Herland
Date: Friday, February 5, 2010 - 3:36 am

On Friday 05 February 2010, Giuseppe Bilotta wrote:

I already maintain a TODO list at the end of the cover letter to the notes 
series. Here is a preview of it (I plan to send the next iteration of 
jh/notes as soon as v1.7.0 is released):


- Suggestion by Matthieu Moy and Sverre Rabbelier:
  Add notes support to git-format-patch, where note contents in
  refs/notes/format-patch are added to the "comments section"
  (i.e. following the '---' separator) of generated patches.

- Better integration with rebase/amend/cherry-pick. Optionally bring
  notes across a commit rewrite. Controlled by command-line options
  and/or config variables. Add "git notes move" and "git notes copy"
  to suit. Junio says:
    I used to fix minor issues (styles, decl-after-stmt, etc.) using
    rebase-i long after running "am" in bulk, but these days I find
    myself going back to my "inbox" and fix them in MUA; this is
    only because I know these notes do not propagate across rebases
    and amends -- adjusting the workflow to the tool's limitation is
    not very good.

- Junio says:
  The interface to tell tools to use which notes ref to use should be
  able to say "these refs", not just "this ref" i.e. GIT_NOTES_REF=a:b
  just like PATH=a:b:c...); I am fairly certain that we would want to
  store different kind of information in separate notes trees and
  aggregate them, as we gain experience with notes.

- Junio says:
  There should be an interface to tell tools to use which notes refs via
  command line options; "!alias" does not TAB-complete, and "git lgm"
  above doesn't, either. "git log --notes=notes/amlog --notes=notes/other"
  would probably be the way to go.

- Add a "git notes grep" subcommand: Junio says:
  While reviewing the "inbox", I sometimes wonder if I applied a message
  to somewhere already, but there is no obvious way to grep in the notes
  tree and get the object name that a note is attached to.  Of course I
  know I can "git grep -c johan@herland.net notes/amlog" and it will give
  me something like:

    notes/amlog:65807ee697a28cb30b8ad38ebb8b84cebd3f255d:1
    notes/amlog:c789176020d6a008821e01af8b65f28abc138d4b:1

  but this won't scale and needs scripting to mechanize, once we start
  rebalancing the notes tree with different fan-outs.  The end user (me
  in this case) is interested in "set of objects that match this grep
  criteria", not "the pathnames the notes tree's implementation happens
  to use to store notes for them in the hierarchy".

- Handle note objects that are not blobs, but trees

(- Rewrite fast-import notes code to use new notes API with non-note 
support)


Have fun! :)

...Johan


-- 
Johan Herland, <johan@herland.net>
www.herland.net
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/4] gitweb: preliminary notes support, Giuseppe Bilotta, (Thu Feb 4, 9:18 am)
[PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Thu Feb 4, 9:18 am)
[PATCH 2/4] gitweb: show notes in shortlog view, Giuseppe Bilotta, (Thu Feb 4, 9:18 am)
[PATCH 3/4] gitweb: show notes in log, Giuseppe Bilotta, (Thu Feb 4, 9:18 am)
[PATCH 4/4] gitweb: show notes in commit(diff) view, Giuseppe Bilotta, (Thu Feb 4, 9:18 am)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Thu Feb 4, 9:33 am)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Thu Feb 4, 9:46 am)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Thu Feb 4, 10:21 am)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Thu Feb 4, 1:08 pm)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Thu Feb 4, 2:03 pm)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Thu Feb 4, 2:07 pm)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Thu Feb 4, 4:20 pm)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Thu Feb 4, 4:38 pm)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Thu Feb 4, 5:44 pm)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Thu Feb 4, 5:55 pm)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Fri Feb 5, 1:42 am)
Re: [PATCH 1/4] gitweb: notes feature, Johan Herland, (Fri Feb 5, 3:36 am)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Fri Feb 5, 9:10 am)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Fri Feb 5, 2:31 pm)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Fri Feb 5, 3:31 pm)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Fri Feb 5, 4:44 pm)
Re: [PATCH 2/4] gitweb: show notes in shortlog view, Jakub Narebski, (Fri Feb 5, 5:18 pm)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Sat Feb 6, 1:16 am)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Sat Feb 6, 2:02 am)
Re: [PATCH 2/4] gitweb: show notes in shortlog view, Giuseppe Bilotta, (Sat Feb 6, 2:24 am)
Re: [PATCH 3/4] gitweb: show notes in log, Jakub Narebski, (Sat Feb 6, 5:57 am)
Re: [PATCH 3/4] gitweb: show notes in log, Giuseppe Bilotta, (Sat Feb 6, 6:14 am)
Re: [PATCH 4/4] gitweb: show notes in commit(diff) view, Jakub Narebski, (Sat Feb 6, 6:16 am)
Re: [PATCH 4/4] gitweb: show notes in commit(diff) view, Giuseppe Bilotta, (Sat Feb 6, 7:15 am)
Re: [PATCH 4/4] gitweb: show notes in commit(diff) view, Jakub Narebski, (Sat Feb 6, 7:34 am)
Re: [PATCH 4/4] gitweb: show notes in commit(diff) view, Giuseppe Bilotta, (Sat Feb 6, 9:13 am)
Re: [PATCH 3/4] gitweb: show notes in log, Jakub Narebski, (Sat Feb 6, 2:47 pm)
Re: [PATCH 4/4] gitweb: show notes in commit(diff) view, Jakub Narebski, (Sat Feb 6, 2:50 pm)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Sat Feb 6, 3:14 pm)
Re: [PATCH 4/4] gitweb: show notes in commit(diff) view, Giuseppe Bilotta, (Sat Feb 6, 3:17 pm)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Sat Feb 6, 3:58 pm)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Sat Feb 6, 6:20 pm)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Sat Feb 6, 6:38 pm)
Re: [PATCH 1/4] gitweb: notes feature, Johan Herland, (Sat Feb 6, 6:48 pm)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Sun Feb 7, 3:57 am)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Sun Feb 7, 4:08 am)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Sun Feb 7, 4:11 am)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Sun Feb 7, 4:14 am)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Sun Feb 7, 5:41 am)
Re: [PATCH 1/4] gitweb: notes feature, Junio C Hamano, (Sun Feb 7, 11:38 am)
Re: [PATCH 1/4] gitweb: notes feature, Giuseppe Bilotta, (Sun Feb 7, 1:11 pm)
Re: [PATCH 1/4] gitweb: notes feature, Jakub Narebski, (Sun Feb 7, 2:08 pm)