Re: [PATCH] fix threaded grep for machines with only one cpu

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Tuesday, February 16, 2010 - 3:54 pm

Nicolas Pitre <nico@fluxnic.net> writes:


I don't think Heiko is saying he was offended by you, but is saying he was
offended by me saying "Don't they teach this in schools anymore?"  I was
simply curious about the answer to that question.  If they don't teach C,
it is not Heiko's fault---no need to get offended.  I admit that I did go
"Huh?  Never repeat?  What's the point?" when I first saw the idiom.

By learning and sticking to idioms people get more efficient, because
there is no need to think if it is better to have "do { ... } while()"
inside or outside yourself; cleverer people have already figured out the
best way and that is how idioms came about.  Once you learn them, your
eyes will coast over the outer cruft and focus on the essential part of
the macro "..." without even spending any extra effort to actively squelch
the surrounding "do {" and "} while (0)".  These literally become part of
background noise and do not bother you anymore to the point that they are
not even ugly.

Think of this as a mutual/collective learning experience.  As Dscho said
on this topic on msysgit list, Heiko _is_ the hero in figuring out what
was originally broken, even though the proposed solution might have been
suboptimal.  I know figuring out what is broken have taken a lot more
effort than my looking over his solution and reaching a better solution.
Correct diagnosis is often more than 80% of solving a problem.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] fix threaded grep for machines with only one cpu, Johannes Schindelin, (Mon Feb 15, 4:09 pm)
Re: [PATCH] fix threaded grep for machines with only one cpu, Fredrik Kuivinen, (Tue Feb 16, 12:54 am)
Re: [PATCH] fix threaded grep for machines with only one cpu, Johannes Schindelin, (Tue Feb 16, 1:15 am)
Re: [PATCH] fix threaded grep for machines with only one cpu, Junio C Hamano, (Tue Feb 16, 12:20 pm)
Re: [PATCH] fix threaded grep for machines with only one cpu, Sverre Rabbelier, (Tue Feb 16, 12:26 pm)
Re: [PATCH] fix threaded grep for machines with only one cpu, Johannes Schindelin, (Tue Feb 16, 1:19 pm)
Re: [PATCH] fix threaded grep for machines with only one cpu, Junio C Hamano, (Tue Feb 16, 3:54 pm)
Re: [PATCH] fix threaded grep for machines with only one cpu, Johannes Schindelin, (Tue Feb 16, 6:01 pm)
Re: Re: [PATCH] fix threaded grep for machines with only o ..., Johannes Schindelin, (Thu Feb 18, 2:10 am)