[PATCH 1/2] hash-object: support --stdin-paths with --no-filters

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Erik Faye-Lund
Date: Friday, February 12, 2010 - 10:52 am

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 builtin-hash-object.c  |    8 ++++----
 t/t1007-hash-object.sh |    4 ----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/builtin-hash-object.c b/builtin-hash-object.c
index 6a5f5b5..080af1a 100644
--- a/builtin-hash-object.c
+++ b/builtin-hash-object.c
@@ -33,6 +33,8 @@ static void hash_object(const char *path, const char *type, int write_object,
 	hash_fd(fd, type, write_object, vpath);
 }
 
+static int no_filters;
+
 static void hash_stdin_paths(const char *type, int write_objects)
 {
 	struct strbuf buf = STRBUF_INIT, nbuf = STRBUF_INIT;
@@ -44,7 +46,8 @@ static void hash_stdin_paths(const char *type, int write_objects)
 				die("line is badly quoted");
 			strbuf_swap(&buf, &nbuf);
 		}
-		hash_object(buf.buf, type, write_objects, buf.buf);
+		hash_object(buf.buf, type, write_objects,
+		    no_filters ? NULL : buf.buf);
 	}
 	strbuf_release(&buf);
 	strbuf_release(&nbuf);
@@ -60,7 +63,6 @@ static const char *type;
 static int write_object;
 static int hashstdin;
 static int stdin_paths;
-static int no_filters;
 static const char *vpath;
 
 static const struct option hash_object_options[] = {
@@ -100,8 +102,6 @@ int cmd_hash_object(int argc, const char **argv, const char *prefix)
 			errstr = "Can't specify files with --stdin-paths";
 		else if (vpath)
 			errstr = "Can't use --stdin-paths with --path";
-		else if (no_filters)
-			errstr = "Can't use --stdin-paths with --no-filters";
 	}
 	else {
 		if (hashstdin > 1)
diff --git a/t/t1007-hash-object.sh b/t/t1007-hash-object.sh
index fd98e44..1509fe3 100755
--- a/t/t1007-hash-object.sh
+++ b/t/t1007-hash-object.sh
@@ -65,10 +65,6 @@ test_expect_success "Can't use --path with --stdin-paths" '
 	echo example | test_must_fail git hash-object --stdin-paths --path=foo
 '
 
-test_expect_success "Can't use --stdin-paths with --no-filters" '
-	echo example | test_must_fail git hash-object --stdin-paths --no-filters
-'
-
 test_expect_success "Can't use --path with --no-filters" '
 	test_must_fail git hash-object --no-filters --path=foo
 '
-- 
1.7.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/2] hash-object: support --stdin-paths with --no-f ..., Erik Faye-Lund, (Fri Feb 12, 10:52 am)
[PATCH 2/2] git-svn: support fetch with autocrlf on, Erik Faye-Lund, (Fri Feb 12, 10:52 am)
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on, Erik Faye-Lund, (Sat Feb 13, 7:16 am)
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on, Johannes Schindelin, (Sat Feb 13, 4:55 pm)
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on, Johannes Schindelin, (Sat Feb 13, 4:59 pm)
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on, Erik Faye-Lund, (Sat Feb 13, 5:27 pm)
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on, Johannes Schindelin, (Sat Feb 13, 5:46 pm)
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on, Erik Faye-Lund, (Sat Feb 13, 6:04 pm)