Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:

quoted text
> Currently, the existence of rebase-merge/ is tested with 'test -d',
> while the existence of rebase-apply/ is tested by creating the
> directory and then deleting it again. Any good reason for this?

I don't recall how the merge side reached the current shape of the code,
but I think the rebase-apply one was that we wanted to make sure not only
we don't have a directory but also we actually _can_ create one.  If
somebody had a bad permission set, "test -d" wouldn't help us much.  We
would fail later and error diagnosis codepath should do the right thing
anyway, so it is not a correctness issue, but is more about attempting to
notice an error early rather than late.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html