Re: [PATCH v2 3/4] userdiff: fix typo in ruby and python word regexes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Saturday, December 18, 2010 - 2:02 pm

Thomas Rast <trast@student.ethz.ch> writes:


Thanks.

Couldn't we have found this without your "sanity check" patch?  Are we
ignoring error returns from regcomp() in some codepath, or is it just that
we are catching them but our test suite lacks ruby and python test
vectors?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
html userdiff is not showing all my changes, Scott Johnson, (Tue Dec 14, 8:47 pm)
Re: html userdiff is not showing all my changes, Michael J Gruber, (Wed Dec 15, 2:06 am)
Re: html userdiff is not showing all my changes, Matthijs Kooijman, (Wed Dec 15, 2:12 am)
Re: html userdiff is not showing all my changes, Michael J Gruber, (Wed Dec 15, 2:29 am)
[PATCH 0/4] --word-regex sanity checking and such, Thomas Rast, (Wed Dec 15, 8:13 am)
[PATCH 3/4] userdiff: fix typo in ruby word regex, Thomas Rast, (Wed Dec 15, 8:13 am)
Re: [PATCH 0/4] --word-regex sanity checking and such, Thomas Rast, (Wed Dec 15, 12:51 pm)
Re: [PATCH 0/4] --word-regex sanity checking and such, Scott Johnson, (Wed Dec 15, 1:48 pm)
[PATCH v2 0/4] --word-regex sanity checking and such, Thomas Rast, (Sat Dec 18, 9:17 am)
Re: [PATCH v2 0/4] --word-regex sanity checking and such, Junio C Hamano, (Sat Dec 18, 1:48 pm)
Re: [PATCH v2 3/4] userdiff: fix typo in ruby and python w ..., Junio C Hamano, (Sat Dec 18, 2:02 pm)