Re: [PATCH 3/4] push: make non-fast-forward help message configurable

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeff King
Date: Sunday, September 6, 2009 - 12:23 am

On Sun, Sep 06, 2009 at 12:09:07AM -0700, Junio C Hamano wrote:


The best related English phrase I can think of is that the person is a
"back seat driver". The phrase "armchair $X" also comes to mind (e.g.,
"armchair critic"), though that is usually to indicate that the armchair
critic is giving _bad_ advice, not being well-versed in the field they
are advising about. And I think you are not so much saying the advice is
wrong as much as it is unwanted because you already know it.

I can't think of a noun that describes the advice itself, though
(nagging? ;) ).


Git config files are utf8, right? You can always internationalize this
feature. :)

Thinking on it more, I think "advice" is the right word. It is not about
arbitrary messages; it is about particular messages which try to advise.
You would never want this feature to cover messages that are
informational about a particular state or action that has occurred. Only
"maybe you should try this" messages.

I'll re-roll 3 and 4 based on that, but I will wait a bit to see any
more comments. Probably you should consider patches 1 and 2 as a
potential series for 'maint', and 3 and 4 should be spun off into their
own series (they really only rely textually on the first two).

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC/PATCH 0/4] make helpful messages optional, Jeff King, (Sat Sep 5, 11:44 pm)
[PATCH 2/4] push: re-flow non-fast-forward message, Jeff King, (Sat Sep 5, 11:47 pm)
Re: [PATCH 3/4] push: make non-fast-forward help message c ..., Jeff King, (Sun Sep 6, 12:23 am)
Re: [RFC/PATCH 0/4] make helpful messages optional, Matthieu Moy, (Sun Sep 6, 4:53 am)
[PATCH 0/2] configurable advice messages, Jeff King, (Wed Sep 9, 4:26 am)