Home » Mailing list archives » git » 2009 » August » 28

Re: [PATCH 08/14] Test for WIN32 instead of __MINGW32_

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paolo Bonzini
Subject: Re: [PATCH 08/14] Test for WIN32 instead of __MINGW32_
Date: Friday, August 28, 2009 - 1:15 am

Since you are doing this, you may as well change patch 3 from

+#if (defined(__MINGW32__) && defined(__GNUC__) && __GNUC__ < 4) || 
defined(_MSC_VER)

to this:

#if defined WIN32 && (!defined (__GNUC__) || __GNUC__ < 4))

Paolo
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 04/14] Add define guards to compat/win32.h, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 05/14] Change regerror() declaration from K&amp;R style ..., Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 06/14] mingw.c: Use the O_BINARY flag to open files, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 07/14] Fix __stdcall/WINAPI placement and function ..., Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 08/14] Test for WIN32 instead of __MINGW32_, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 09/14] Avoid including windows.h in winansi.c for M ..., Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 10/14] Add empty header files for MSVC port, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 11/14] Add MinGW header files to build git with MSVC, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 12/14] Add platform files for MSVC porting, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 13/14] Add MSVC project files, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
[PATCH 14/14] Add README and gitignore file for MSVC build, Marius Storm-Olsen, (Fri Aug 21, 6:30 am)
Re: [PATCH 05/14] Change regerror() declaration from K&amp;R s ..., Frank Li, (Fri Aug 21, 7:37 am)
Re: [msysGit] [PATCH 07/14] Fix __stdcall/WINAPI placement ..., Johannes Sixt, (Fri Aug 21, 10:37 am)
Re: [msysGit] [PATCH 07/14] Fix __stdcall/WINAPI placement ..., Marius Storm-Olsen, (Fri Aug 21, 12:42 pm)
[PATCH v2 05/14] Change regerror() definition from K&amp;R sty ..., Marius Storm-Olsen, (Fri Aug 21, 1:10 pm)
Re: [PATCH 09/14] Avoid including windows.h in winansi.c f ..., Junio C Hamano, (Fri Aug 21, 2:02 pm)
Re: [PATCH 09/14] Avoid including windows.h in winansi.c f ..., Reece Dunn, (Fri Aug 21, 2:16 pm)
Re: [PATCH v2 05/14] Change regerror() definition from K&amp;R ..., Frank Li, (Fri Aug 21, 5:15 pm)
Re: [PATCH 09/14] Avoid including windows.h in winansi.c f ..., Marius Storm-Olsen, (Sat Aug 22, 4:40 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Thiago Farina, (Sun Aug 23, 9:26 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Reece Dunn, (Sun Aug 23, 11:22 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Marius Storm-Olsen, (Sun Aug 23, 11:59 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Thiago Farina, (Sun Aug 23, 12:29 pm)
Re: [msysGit] Re: [PATCH 14/14] Add README and gitignore f ..., Marius Storm-Olsen, (Mon Aug 24, 12:03 am)
Re: [PATCH v2 05/14] Change regerror() definition from K&amp;R ..., Erik Faye-Lund, (Mon Aug 24, 2:42 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Frank Li, (Tue Aug 25, 7:32 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Thiago Farina, (Tue Aug 25, 10:24 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Frank Li, (Thu Aug 27, 6:16 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Thiago Farina, (Thu Aug 27, 7:26 am)
Re: [PATCH 08/14] Test for WIN32 instead of __MINGW32_, Paolo Bonzini, (Fri Aug 28, 1:15 am)
Re: [PATCH 14/14] Add README and gitignore file for MSVC build, Erik Faye-Lund, (Mon Sep 7, 5:26 am)