login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
git
»
2009
»
May
»
12
Re: [PATCH] Fix type-punning issues
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Johannes Schindelin
Subject:
Re: [PATCH] Fix type-punning issues
Date: Tuesday, May 12, 2009 - 1:13 am
Hi, On Mon, 11 May 2009, Dan McGee wrote:
quoted text
> In these two places we are casting part of our unsigned char sha1 array > into an unsigned int, which violates GCCs strict-aliasing rules (and > probably other compilers). In addition, we had two hashing functions > defined in object.c. Keep the one function that is "correct" and adopt > the other ones to fit. > > decorate.c: In function ‘hash_obj’: > decorate.c:11: warning: dereferencing type-punned pointer will break > strict-aliasing rules
FWIW we have the same issue in msysGit, having installed GCC 4.4.0 recently, but I did not dare to send my "fix". Yours is much nicer. Thanks, Dscho
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] Fix type-punning issues
, Dan McGee
, (Mon May 11, 6:17 pm)
Re: [PATCH] Fix type-punning issues
, Junio C Hamano
, (Tue May 12, 12:57 am)
Re: [PATCH] Fix type-punning issues
, Johannes Schindelin
, (Tue May 12, 1:13 am)
Re: [PATCH] Fix type-punning issues
, Dan McGee
, (Mon May 18, 9:32 pm)
[PATCH 1/3] Unify signedness in hashing calls
, Dan McGee
, (Mon May 18, 9:34 pm)
[PATCH 2/3] Convert hash functions to char instead of stru ...
, Dan McGee
, (Mon May 18, 9:34 pm)
[PATCH 3/3] Unify sha1 char hash functions
, Dan McGee
, (Mon May 18, 9:34 pm)
Re: [PATCH 2/3] Convert hash functions to char instead of ...
, Johannes Sixt
, (Mon May 18, 11:23 pm)
Re: [PATCH 2/3] Convert hash functions to char instead of ...
, Junio C Hamano
, (Tue May 19, 12:04 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Rafael J. Wysocki
[Bug #16136] Linux 2.6.34 causes system lockup on Compaq Presario 2200 Laptop
Joerg Roedel
Re: [patch] dma-debug: off by one issue
Tetsuo Handa
Re: [AppArmor #7 0/13] AppArmor security module
Pekka Enberg
Re: BUG in free_block (tainted)
Jakub Narebski
Re: [PATCH] gitweb: Fix shortlog only showing HEAD revision.
git
:
Christian Stimming
git-gui: Fix broken revert confirmation.
Johannes Schindelin
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
Mark Burton
Re: [PATCH] builtin-branch: highlight current remote branches with an asterisk
Junio C Hamano
Re: git-svnimport
Junio C Hamano
Re: [PATCH 6/6] Teach core object handling functions about gitlinks
linux-netdev
:
Nick Piggin
Re: Kernel WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98()
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Amit Kumar Salecha
[PATCH NEXT 10/10] qlcnic: add cksum flag
Patrick McHardy
Re: [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt_condition
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
ath9k: Added get_survey callback in order to get channel noise
Linux Kernel Mailing List
ALSA: snd-usb-caiaq: Do not expose hardware input mode 0 of A4DJ
Linux Kernel Mailing List
cpumask: make irq_set_affinity() take a const struct cpumask
Linux Kernel Mailing List
V4L/DVB (9041): Add support YUAN High-Tech STK7700D (1164:1f08)
openbsd-misc
:
Conor
Re: RFID Reader
Josh Grosse
ssh/sshd challenge-response seems to have stopped working in -current
Stuart Henderson
Re: SquidGuard problem
Henning Brauer
Re: 3ware hardware raid support?
Ryan McBride
Re: Packets Per Second Limit?
Colocation donated by:
Syndicate