Re: [PATCH 0/6] Add core.autocrlf=true on cygwin by default during tests

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric Blake
Date: Monday, May 11, 2009 - 1:04 pm

Don Slutz <Don.Slutz <at> SierraAtlantic.com> writes:


I help maintain the cygwin packaging of git, and I don't particularly like 
patch 1/6.  Cygwin very much recommends that users stick with binary mounts, 
where cr's are not inserted/stripped by default, and enabling autocrlf in that 
situation is asking for problems (namely, the same set of problems as you would 
have on Linux with autocrlf=true).  While adding an environment variable is 
useful for the case of a user building git on cygwin with the intent of using a 
text-mode mount, it goes against the grain of cygwin's recommendation of not 
using text-mode mounts in the first place.  I would rather see the default 
remain false, even on cygwin, unless the person building git takes steps to 
activate it themselves.

-- 
Eric Blake



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 0/6] Add core.autocrlf=true on cygwin by defaul ..., Eric Blake, (Mon May 11, 1:04 pm)
Re: [PATCH 0/6] Add core.autocrlf=true on cygwin by defaul ..., Johannes Schindelin, (Mon May 11, 1:54 pm)