Hi,

On Mon, 9 Feb 2009, Ingo Molnar wrote:

quoted text
> * Junio C Hamano <gitster@pobox.com> wrote:
> 
> > David Symonds <dsymonds@gmail.com> writes:
> > 
> > > On Sat, Feb 7, 2009 at 3:41 PM, Christian Couder
> > > <chriscool@tuxfamily.org> wrote:
> > >
> > >> It might be useful to have a list of always good commits too, and use it
> > >> like this:
> > >>
> > >> $ git bisect start <bad> <good> $(cat always_good.txt)
> > >> $ git bisect skip $(cat always_skipped.txt)
> > >> $ git bisect run ./my_test_script.sh
> > >
> > > Your test script could just do this at its start instead:
> > >
> > >   if cat always_good.txt | grep $(rev-parse HEAD); then
> > >     exit 0
> > >   elif cat always_skipped.txt | grep $(rev-parse HEAD); then
> > >     exit 125
> > >   fi
> > 
> > Don't cat a file into grep, please.
> 
> I do it all the time not because i dont know about grep's ability
> to take a file parameter, but because this way it's just a
> special-case of command piping and i can inject other commands as
> i extend/edit the command line interactively, etc.

I think Junio meant using '< $file' type redirection, to avoid an 
unnecessary fork().  (Good habit, avoiding fork()s...)

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html