Re: 026fa0d5ad Breaks installs with absolue $(gitexecdir) and $(template_dir) variables using older GNU makes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Thursday, February 5, 2009 - 1:01 am

Junio C Hamano <gitster@pobox.com> writes:


In other words, I am thinking about applying your patch after amending the 
log message like this.

    [PATCH] config.mak.in: define paths without trailing slash

    The main Makefile defines gitexecdir and template_dir without trailing
    slash.  config.mak.in should do the same to be consistent.

    Signed-off-by: Pascal Obry <pascal@obry.net>

I think the misuse of abspath is a separate issue.

The main Makefile should be made robust not to misdetect the relative vs
absolute, especially because not everybody uses config.mak.autogen, and
because people should be able to override these variables from the command
line of make invocation and the name of the directory with or without
trailing slash ought to mean the same thing.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
026fa0d5ad Breaks installs with absolue $(gitexecdir) and ..., A Large Angry SCM, (Sun Feb 1, 11:24 am)
Re: 026fa0d5ad Breaks installs with absolue $(gitexecdir) ..., Steffen Prohaska, (Thu Feb 5, 12:13 am)
Re: 026fa0d5ad Breaks installs with absolue $(gitexecdir) ..., Junio C Hamano, (Thu Feb 5, 1:01 am)
[PATCH] Makefile: fix misdetection of relative pathnames, Junio C Hamano, (Thu Feb 5, 1:18 am)
Re: [PATCH] Makefile: fix misdetection of relative pathnames, A Large Angry SCM, (Thu Feb 5, 3:16 pm)