Re: [PATCH] fix crash in path.c on Windows

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Wednesday, February 4, 2009 - 4:51 pm

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:


This change does not make sense to me.  The assert is about the initial
iteration beginning at the "root" level, and at the same time previous
iteration ended at dir_sep.  On mingw you would probably need these two as
separate tests.  In other words, I would understand if the fix were like
this:

	if (it begins with dos_prefix) {
        	/* this is never true outside windows */
		copy the dos prefix out and advance comp_start as
        	necessary;
	}
        while (*comp_start) {
        	assert(is_dir_sep(*comp_start));
                while (*++comp_end && !is_dir_sep(*comp_end))
                	; /* nothing */
		...
	}

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] fix crash in path.c on Windows, René Scharfe, (Wed Feb 4, 4:00 pm)
Re: [PATCH] fix crash in path.c on Windows, Junio C Hamano, (Wed Feb 4, 4:51 pm)
Re: [PATCH] fix crash in path.c on Windows, Johannes Sixt, (Thu Feb 5, 12:57 am)
Re: [PATCH] fix crash in path.c on Windows, René Scharfe, (Thu Feb 5, 9:48 am)
Re: [PATCH] fix crash in path.c on Windows, Johannes Sixt, (Thu Feb 5, 10:13 am)
[PATCH] fix t1504 on Windows, René Scharfe, (Thu Feb 5, 12:35 pm)
Re: [PATCH] fix crash in path.c on Windows, Robin Rosenberg, (Thu Feb 5, 1:41 pm)
Re: [PATCH] fix t1504 on Windows, Johannes Sixt, (Fri Feb 6, 5:55 am)
Re: [PATCH] fix t1504 on Windows, Johannes Schindelin, (Fri Feb 6, 6:11 am)
Re: [PATCH] fix t1504 on Windows, Johannes Sixt, (Fri Feb 6, 6:17 am)
Re: [PATCH] fix t1504 on Windows, Johannes Schindelin, (Fri Feb 6, 6:26 am)
Re: [PATCH] fix t1504 on Windows, Johannes Sixt, (Fri Feb 6, 6:36 am)
Re: [PATCH] fix t1504 on Windows, René Scharfe, (Fri Feb 6, 10:18 am)
Re: [PATCH] fix t1504 on Windows, Johannes Sixt, (Fri Feb 6, 12:23 pm)
Re: [PATCH] fix t1504 on Windows, René Scharfe, (Fri Feb 6, 2:45 pm)
Re: [PATCH] fix t1504 on Windows, René Scharfe, (Fri Feb 6, 5:25 pm)
[PATCH 0/5] Consolidate path normalization functions, Johannes Sixt, (Sat Feb 7, 8:08 am)
[PATCH 3/5] Fix GIT_CEILING_DIRECTORIES on Windows, Johannes Sixt, (Sat Feb 7, 8:08 am)
[PATCH 4/5] Test and fix normalize_path_copy(), Johannes Sixt, (Sat Feb 7, 8:08 am)
[PATCH 5/5] Remove unused normalize_absolute_path(), Johannes Sixt, (Sat Feb 7, 8:08 am)
Re: [PATCH 4/5] Test and fix normalize_path_copy(), Robin Rosenberg, (Sat Feb 7, 5:08 pm)
Re: [PATCH 4/5] Test and fix normalize_path_copy(), Johannes Sixt, (Sun Feb 8, 1:52 am)
Re: [PATCH 4/5] Test and fix normalize_path_copy(), René Scharfe, (Sun Feb 8, 7:46 am)
Re: [PATCH 4/5] Test and fix normalize_path_copy(), Johannes Sixt, (Sun Feb 8, 8:50 am)