Home » Mailing list archives » git » 2009 » February » 4

[PATCH/RFC v3 8/9] show_patch_diff(): remove a call to fstat()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Kjetil Barvik
Subject: [PATCH/RFC v3 8/9] show_patch_diff(): remove a call to fstat()
Date: Wednesday, February 4, 2009 - 5:53 am

Currently inside show_patch_diff() we have an fstat() call after an
ok lstat() call.  Since before the call to fstat() we have already
tested for the link case with S_ISLNK(), the fstat() can be removed.

Signed-off-by: Kjetil Barvik <barvik@broadpark.no>
---
 combine-diff.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/combine-diff.c b/combine-diff.c
index bccc018..4300319 100644
--- a/combine-diff.c
+++ b/combine-diff.c
@@ -713,9 +713,7 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent,
 			result_size = buf.len;
 			result = strbuf_detach(&buf, NULL);
 			elem->mode = canon_mode(st.st_mode);
-		}
-		else if (0 <= (fd = open(elem->path, O_RDONLY)) &&
-			 !fstat(fd, &st)) {
+		} else if (0 <= (fd = open(elem->path, O_RDONLY))) {
 			size_t len = xsize_t(st.st_size);
 			ssize_t done;
 			int is_file, i;
-- 
1.6.1.349.g99fa5

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH/RFC v3 0/9] git checkout: more cleanups, optimisati ..., Kjetil Barvik, (Wed Feb 4, 5:52 am)
[PATCH/RFC v3 1/9] lstat_cache(): small cleanup and optimi ..., Kjetil Barvik, (Wed Feb 4, 5:52 am)
[PATCH/RFC v3 2/9] lstat_cache(): generalise longest_match ..., Kjetil Barvik, (Wed Feb 4, 5:52 am)
[PATCH/RFC v3 3/9] lstat_cache(): swap func(length, string ..., Kjetil Barvik, (Wed Feb 4, 5:52 am)
[PATCH/RFC v3 4/9] unlink_entry(): introduce schedule_dir_ ..., Kjetil Barvik, (Wed Feb 4, 5:52 am)
[PATCH/RFC v3 5/9] create_directories(): remove some memcp ..., Kjetil Barvik, (Wed Feb 4, 5:52 am)
[PATCH/RFC v3 6/9] write_entry(): cleanup of some duplicat ..., Kjetil Barvik, (Wed Feb 4, 5:52 am)
[PATCH/RFC v3 7/9] write_entry(): use fstat() instead of l ..., Kjetil Barvik, (Wed Feb 4, 5:53 am)
[PATCH/RFC v3 8/9] show_patch_diff(): remove a call to fstat(), Kjetil Barvik, (Wed Feb 4, 5:53 am)
[PATCH/RFC v3 9/9] lstat_cache(): print a warning if doing ..., Kjetil Barvik, (Wed Feb 4, 5:53 am)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Johannes Sixt, (Wed Feb 4, 7:01 am)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Junio C Hamano, (Wed Feb 4, 11:41 am)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Kjetil Barvik, (Wed Feb 4, 12:53 pm)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Junio C Hamano, (Wed Feb 4, 1:30 pm)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Johannes Sixt, (Thu Feb 5, 1:14 am)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Johannes Schindelin, (Thu Feb 5, 4:03 am)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Kjetil Barvik, (Fri Feb 6, 4:06 am)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Johannes Schindelin, (Fri Feb 6, 4:26 am)
Re: [PATCH/RFC v3 7/9] write_entry(): use fstat() instead ..., Kjetil Barvik, (Sat Feb 14, 10:50 am)