Home » Mailing list archives » git » 2009 » February » 19

[PATCH 8/8] refs: use warning() instead of fprintf(stderr, "warning: ")

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Miklos Vajna
Subject: [PATCH 8/8] refs: use warning() instead of fprintf(stderr, "warning: ")
Date: Thursday, February 19, 2009 - 5:55 am

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 refs.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/refs.c b/refs.c
index 6eb5f53..fd96824 100644
--- a/refs.c
+++ b/refs.c
@@ -995,7 +995,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
 
 	err = unlink(git_path("logs/%s", lock->ref_name));
 	if (err && errno != ENOENT)
-		fprintf(stderr, "warning: unlink(%s) failed: %s",
+		warning("unlink(%s) failed: %s",
 			git_path("logs/%s", lock->ref_name), strerror(errno));
 	invalidate_cached_refs();
 	unlock_ref(lock);
@@ -1437,8 +1437,7 @@ int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *
 				if (get_sha1_hex(rec + 41, sha1))
 					die("Log %s is corrupt.", logfile);
 				if (hashcmp(logged_sha1, sha1)) {
-					fprintf(stderr,
-						"warning: Log %s has gap after %s.\n",
+					warning("Log %s has gap after %s.",
 						logfile, show_date(date, tz, DATE_RFC2822));
 				}
 			}
@@ -1450,8 +1449,7 @@ int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *
 				if (get_sha1_hex(rec + 41, logged_sha1))
 					die("Log %s is corrupt.", logfile);
 				if (hashcmp(logged_sha1, sha1)) {
-					fprintf(stderr,
-						"warning: Log %s unexpectedly ended on %s.\n",
+					warning("Log %s unexpectedly ended on %s.",
 						logfile, show_date(date, tz, DATE_RFC2822));
 				}
 			}
-- 
1.6.1

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 5/6] Change output &quot;error: &quot; to &quot;Error: &quot; etc, John Tapsell, (Thu Feb 19, 12:36 am)
Re: [PATCH 5/6] Change output &quot;error: &quot; to &quot;Error: &quot; etc, Thomas Rast, (Thu Feb 19, 1:14 am)
Re: [PATCH 5/6] Change output &quot;error: &quot; to &quot;Error: &quot; etc, Jeff King, (Thu Feb 19, 1:17 am)
[PATCH] http-push: using error() and warning() as appropriate, Miklos Vajna, (Thu Feb 19, 5:07 am)
Re: [PATCH] http-push: using error() and warning() as appr ..., Jeff King, (Thu Feb 19, 5:21 am)
[PATCH 0/8] fprintf(stderr, &quot;warning: &quot;) -&gt; warning() patches, Miklos Vajna, (Thu Feb 19, 5:52 am)
[PATCH 1/8] builtin-apply: use warning() instead of fprint ..., Miklos Vajna, (Thu Feb 19, 5:53 am)
[PATCH 2/8] builtin-checkout: use warning() instead of fpr ..., Miklos Vajna, (Thu Feb 19, 5:53 am)
[PATCH 3/8] builtin-fetch-pack: use warning() instead of f ..., Miklos Vajna, (Thu Feb 19, 5:53 am)
[PATCH 4/8] builtin-init-db: use warning() instead of fpri ..., Miklos Vajna, (Thu Feb 19, 5:54 am)
[PATCH 5/8] builtin-rm: use warning() instead of fprintf(s ..., Miklos Vajna, (Thu Feb 19, 5:54 am)
[PATCH 6/8] builtin-show-branch: use warning() instead of ..., Miklos Vajna, (Thu Feb 19, 5:54 am)
[PATCH 7/8] builtin-show-ref: use warning() instead of fpr ..., Miklos Vajna, (Thu Feb 19, 5:55 am)
[PATCH 8/8] refs: use warning() instead of fprintf(stderr, ..., Miklos Vajna, (Thu Feb 19, 5:55 am)
Re: [PATCH 1/8] builtin-apply: use warning() instead of fp ..., Jeff King, (Thu Feb 19, 8:02 pm)
Re: [PATCH 1/8] builtin-apply: use warning() instead of fp ..., Junio C Hamano, (Thu Feb 19, 11:11 pm)
Re: [PATCH 1/8] builtin-apply: use warning() instead of fp ..., Miklos Vajna, (Fri Feb 20, 2:41 am)
Re: [PATCH 1/8] builtin-apply: use warning() instead of fp ..., Miklos Vajna, (Sun Mar 22, 4:36 am)