Home » Mailing list archives » git » 2009 » February » 11

Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Junio C Hamano
Subject: Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention
Date: Wednesday, February 11, 2009 - 10:14 am

Ted Pavlic <ted@tedpavlic.com> writes:


No, this paragraph from Documentation/CodingGuidelines trumps you.

    As for more concrete guidelines, just imitate the existing code
    (this is a good guideline, no matter which project you are
    contributing to). It is always preferable to match the _local_
    convention. New code added to git suite is expected to match
    the overall style of existing code. Modifications to existing
    code is expected to match the style the surrounding code already
    uses (even if it doesn't match the overall style of existing code).

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/3] completion: Convention updates and DIRTYSTATE fix, Ted Pavlic, (Wed Feb 11, 8:37 am)
[PATCH 1/3] completion: For consistency, changed &quot;git rev- ..., Ted Pavlic, (Wed Feb 11, 8:37 am)
[PATCH 2/3] completion: Change &quot;if [...]&quot; to &quot;if test ...&quot; ..., Ted Pavlic, (Wed Feb 11, 8:37 am)
[PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE from b ..., Ted Pavlic, (Wed Feb 11, 8:37 am)
[PATCH 4/3] completion: More fixes to prevent unbound vari ..., Ted Pavlic, (Wed Feb 11, 9:18 am)
Re: [PATCH 1/3] completion: For consistency, changed &quot;git ..., Shawn O. Pearce, (Wed Feb 11, 9:22 am)
Re: [PATCH 2/3] completion: Change &quot;if [...]&quot; to &quot;if test ..., Shawn O. Pearce, (Wed Feb 11, 9:24 am)
Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE fr ..., Shawn O. Pearce, (Wed Feb 11, 9:26 am)
Re: [PATCH 4/3] completion: More fixes to prevent unbound ..., Shawn O. Pearce, (Wed Feb 11, 9:28 am)
Re: [PATCH 2/3] completion: Change &quot;if [...]&quot; to &quot;if test ..., Ted Pavlic, (Wed Feb 11, 9:36 am)
Re: [PATCH 2/3] completion: Change &quot;if [...]&quot; to &quot;if test ..., Junio C Hamano, (Wed Feb 11, 9:46 am)
Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE fr ..., Ted Pavlic, (Wed Feb 11, 9:53 am)
Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE fr ..., Junio C Hamano, (Wed Feb 11, 9:56 am)
Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..., Junio C Hamano, (Wed Feb 11, 10:14 am)
Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE fr ..., Ted Pavlic, (Wed Feb 11, 10:20 am)
Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE fr ..., Shawn O. Pearce, (Wed Feb 11, 11:01 am)