Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE from breaking when CWD is .git

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ted Pavlic
Date: Wednesday, February 11, 2009 - 9:53 am

>> This patch uses "git rev-parse --is-inside-work-tree" to determine

I see.

At first, it seemed like it would be useful to know if the working 
directory was dirty even when you're within .git. However, I guess 
that's problematic when your working tree is in some completely 
unpredictable location. It's probably a bad idea to assume that work-tree=..

So you're right... there's a logical problem with having showDirtyState 
turned on when within .git. It should be disabled there.

So I'll check for "git rev-parse --is-inside-git-dir" and disable 
showDirtyState appropriately.

--Ted

-- 
Ted Pavlic <ted@tedpavlic.com>

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE fr ..., Ted Pavlic, (Wed Feb 11, 9:53 am)