On Wednesday 04 November 2009, Sverre Rabbelier wrote:
quoted text
> This patch introduces parts of a Python package called
> "git_remote_helpers" containing the building blocks for
> python helper.
> The actual remote helpers itself are NOT part of this patch.
> 
> The patch includes the necessary Makefile additions to build and install
> the git_remote_cvs Python package along with the rest of Git.

There are a few typos in the above. How about:

  This patch introduces parts of a Python package called
  "git_remote_helpers" containing the building blocks for
  remote helpers written in Python.
  No actual remote helpers are part of this patch, the patch
  only includes the common basics needed to start writing such
  helpers.

quoted text
> The patch includes the necessary Makefile additions to build and install
> the git_remote_cvs Python package along with the rest of Git.

s/git_remote_cvs/git_remote_helpers/

quoted text
> This patch is based on Johan Herland's git_remote_cvs patch and
> has been improved by the following contributions:
> - David Aguilar: Lots of Python coding style fixes
> - David Aguilar: DESTDIR support in Makefile
> 
> Cc: David Aguilar <davvid@gmail.com>
> Cc: Johan Herland <johan@herland.net>
> Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
> ---

Otherwise it all looks good. Nice work!


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html