git mailing list

FromSubjectsort iconDate
Alex Chiang
[StGIT PATCH] allow --cc=myself to work again
commit cd74a041 filtered duplicate email addresses, especially with the --auto option. However, it broke a common practice of cc'ing yourself on a patch. [nb, I don't do this myself, but there are several legit reasons] This patch allows you to do something like: stg mail --to=<someaddr> --cc=<myaddr> --auto <patch> Under my testing, with <myaddr> in the Signed-off-by: path: - we still do not send duplicates to <myaddr> (cd74a041 still holds) - we do not Cc: <myaddr> unless ...
Nov 13, 12:27 pm 2009
Jeff Epler
cherry-pick vs submodule, conflicts
A fellow git user of mine encountered an unexpected problem cherry- picking from one branch to another. The conflict was 'added by us: sub' and I created a small program that leads to the same message. #!/bin/bash # This script demonstrates that it doesn't work to cherry-pick when some (not # even touched) path is a submodule in HEAD but a regular subdirectory in the # branch being picked from. # # Furthermore, when using 'git mergetool', the (desired?) action 'c' # gives the error "fatal: ...
Nov 13, 11:05 am 2009
Shameem Ahamed
Warning while cloning remote repository
Hi, I ran in to a warning message while cloning a remote repository. The message is warning: remote HEAD refers to nonexistent ref, unable to checkout. After the cloning i couldn't see any remote files. The .git folder is created successfully. Regards, Shameem --
Nov 13, 3:20 am 2009
Johan 't Hart
Re: Warning while cloning remote repository
try git checkout -t origin/master on the clone.. Maybe its a workaround? --
Nov 13, 12:34 pm 2009
Stefan Naewe
git am and CRLF files
Hi there. I have: $ git version git version 1.6.5.1.1367.gcd48 $ git config --get core.autocrlf false A repository with some UNIX (LF) and some Windows (CRLF) files. (and no: I will not change the files. My editors handle CRLF and LF correctly) My problem: 'git am' can't handle changes in CRLF files because the patch gets converted (by git mailsplit) to contain only LF. Which is wrong IMHO. git-am on my msysgit version looks like this (lines: ...
Nov 13, 2:44 am 2009
michele
send an email with logs after push
Hi guys, I'm using git for a collaborative development and I'm trying to implement a notification system. I want to automatically send an email containing the log of each commit after a push. The email should contain the titles of the commits done between the previous and the last push. The push action publish the repository on a public_html directory in one other machine. Do you have any suggestion to implement this? Thanks --
Nov 13, 1:46 am 2009
Pascal Obry
Re: send an email with logs after push
I'm doing that. In the post-receive hook I have: << while read oldrev newrev ref; do trac_post_receive_record_log "$oldrev" "$newrev" "$ref" gtest send_mail_post_receive "$oldrev" "$newrev" "$ref" gtest \ pascal@obry.net another@here.com the trac_post_receive_record_log is to add log into trac bug tracker. the send_mail_post_receive is to send a message to the recipients listed. The 4th parameter is the name of the project. The send_mail_post_receive function ...
Nov 13, 1:55 am 2009
Matthieu Moy
Re: send an email with logs after push
See also post-receive-email in git/contrib/hooks/, probably installed somewhere like by your distro. In the .git/hooks/post-receive.sample installed by default by "git init", this should be a matter of uncommenting one line. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ --
Nov 13, 3:42 am 2009
michele
Re: send an email with logs after push
On Fri, 13 Nov 2009 11:42 +0100, "Matthieu Moy" Thank you for your suggestions. I've added a new post-receive hook using the code from post-receive-email. The hook is executable and is placed in the remote directory. The push is made from my local pc via ssh, but after the push nothing seems to happen: the hook is not executed on the server side. It does not depend from the code inside the hook: even the unique "touch foobar" command does not work. Where do I have to look? Thanks --
Nov 13, 7:18 am 2009
Shameem Ahamed
error while cloning a remote repository
Hi, I ran in to a warning message while cloning a remote repository. The message is warning: remote HEAD refers to nonexistent ref, unable to checkout. After the cloning i couldn't see any remote files. The .git folder is created successfully. Regards, Shameem --
Nov 12, 11:38 pm 2009
Shawn O. Pearce
Re: error while cloning a remote repository
Contact the repository owner and let them know. The error occurs because their HEAD symbolic reference points to a branch that does not exist. They can fix this by running `git symbolic-ref HEAD refs/heads/$branch` to point I think you may be able to do: $ git branch -r $ git reset --hard $branch where $branch is one of the origin/ names printed by branch -r. Because the source repository didn't tell us what default branch name you should use (it has a bad HEAD) I can't suggest ...
Nov 13, 8:10 am 2009
Tim Henigan
[PATCH] Update 'git remote' usage and man page to match.
This commit: 1) Removes documentation of '--verbose' from the synopsis portion of the usage string since it is a general option. 2) Removes the 'remote' option from 'git remote update' in the man page. This option had already been removed from the usage string in the code, but the man page was not updated to match. Signed-off-by: Tim Henigan <tim.henigan@gmail.com> --- This is a resend of the patch at: http://article.gmane.org/gmane.comp.version-control.git/132732 I forgot to ...
Nov 12, 6:15 pm 2009
Nanako Shiraishi
Re: [PATCH] Update 'git remote' usage and man page to match.
The second change is good but why do you remove -v from the synopsis section? Why is it a good idea? Manual pages for many other commands list --verbose in their synopsis section. --
Nov 13, 3:19 pm 2009
Jakub Narebski
[RFC/PATCH 0/3] gitweb: Refactor common parts of log-lik ...
This series extracts common parts of log-like views: 'log', 'shortlog' and 'history' view, into git_log_generic() subroutine. This unification of code reduces code duplication, and brings features such as limiting the list of commits displayed using $hash_parent{,_base} from 'shortlog' view (added in ec3e97b (gitweb: shortlog now also obeys $hash_parent, 2008-08-08)). I have tested this series a bit (it passes both t9500 and t9501 test), but I didn't test all the corner cases. This series ...
Nov 12, 6:02 pm 2009
Jakub Narebski
[PATCH 1/3] gitweb: Refactor 'log' action generation, ad ...
Put the main part of 'log' view generation into git_log_body, similarly how it is done for 'shortlog' and 'history' views (and also for 'tags' and 'heads' views). This is preparation for extracting common code between 'log', 'shortlog' and 'history' actions. Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This is pure refactoring: output should change. gitweb/gitweb.perl | 81 ++++++++++++++++++++++++++++++--------------------- 1 files changed, 48 insertions(+), 33 ...
Nov 12, 6:02 pm 2009
Jakub Narebski
[PATCH 2/3] gitweb: Refactor common parts of 'log' and ' ...
Put the common parts of git_log and git_shortlog into git_log_generic subroutine: git_log and git_shortlog are now thin wrappers calling git_log_generic with appropriate arguments. The unification of code responsible for 'log' and 'shorlog' actions lead to the following changes in gitweb output * 'tree' link in page_nav now uses $hash parameter, as was the case for 'shortlog' but not for 'log' * 'log' view now respect $hash_parent limiting, like 'shortlog' did * 'log' view doesn't have ...
Nov 12, 6:02 pm 2009
Jakub Narebski
[PATCH 3/3] gitweb: Make 'history' view (re)use git_log_ ...
Make git_history use git_log_generic, passing git_history_body as one of its paramaters. This required changes to git_log_generic, in particular passing more things as parameters. While refactoring common code of 'log', 'shortlog' and 'history' view, we did unify pagination, using always the form used by 'history' view, namely first * prev * next in place of HEAD * prev * next used by 'log' and 'shortlog' views. The 'history' view now supports commit limiting via 'hpb' ...
Nov 12, 6:02 pm 2009
Nanako Shiraishi
Re: [PATCH 1/3] gitweb: Refactor 'log' action generation ...
Did you mean "should not change"? -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ --
Nov 13, 4:10 pm 2009
Jakub Narebski
Re: [PATCH 1/3] gitweb: Refactor 'log' action generation ...
Yes, of course, it should be "output should not change" (as opposed to later patches, which unify not only code but some of looks). -- Jakub Narebski Poland --
Nov 13, 4:59 pm 2009
Sam Vilain
Re: [PATCH 2/2] git-svn: handle SVN merges from revision ...
So you made a failing test and then added the implementation for it? Interesting strategy :). I'd probably not repeat the same sentence twice though. Thanks for contributing this. There might be other bugs too, especially when upstream has a more complicated merge hierarchy ... apparently svn tends to get it wrong, so checking for all commits might not work in that case. It would be nice if "dcommit" could make these commits, too... Sam --
Nov 12, 5:47 pm 2009
Toby Allsopp
Re: [PATCH 2/2] git-svn: handle SVN merges from revision ...
Hmm, it makes perfect sense to me :-) Does the explanation in 1/2 make more sense? The first sentence describes what Subversion does, the second what Oh yes, SVN gets the merges wrong in an alarming number of cases, it's really shocking. I only stay sane at work because I tell myself that Yes. Toby. --
Nov 12, 6:03 pm 2009
Jeff King
Re: git status internals and line endings
Sounds like the core.autocrlf setting (see "git help config"), which I believe is set by default on Windows. -Peff --
Nov 12, 5:15 pm 2009
Marc Strapetz
Re: git status internals and line endings
I have checked both $GIT_DIR/config and ~/.gitconfig and autocrlf has not been set. I have then set autocrlf = false for the Windows repository and still the file didn't show up as modified. On Linux, I've added autocrlf = true (resp. autocrlf = input) for the repository and still the file shows up as modified. Not that I don't like this behavior, but I don't understand it :) Windows Git version is 1.6.5.1, Linux version is 1.6.3.3. -- Best regards, Marc Strapetz ============= syntevo ...
Nov 13, 1:08 am 2009
Erik Faye-Lund
Re: git status internals and line endings
On Fri, Nov 13, 2009 at 9:08 AM, Marc Strapetz In order to make changes to core.autocrlf effective, you need to delete .git/index and perform a hard reset: $ rm .git/index $ git reset --hard Did you do this before checking if the files were modified? -- Erik "kusma" Faye-Lund --
Nov 13, 2:04 am 2009
Peter Krefting
Re: git status internals and line endings
It is usually set by default by the installer. Look at %INSTALLDIR%\etc\gitconfig, it should contain [core] autoCRLF = true among other things. -- \\// Peter - http://www.softwolves.pp.se/ --
Nov 13, 2:40 am 2009
Marc Strapetz
Re: git status internals and line endings
This solved my problem. Thank you! -- Best regards, Marc Strapetz ============= syntevo GmbH http://www.syntevo.com http://blog.syntevo.com --
Nov 13, 4:01 am 2009
Nicolas Pitre
Re: Git in next is broken
Without the "ref_map = next" there is no change: glibc still complains about corruption and abort the execution. With the "ref_map = next" then git simply segfaults. I simply have zero time to investigate the issue myself now unfortunately. Nicolas --
Nov 12, 9:50 pm 2009
Julian Phillips
Re: Git in next is broken
I was half right about "ref_map = next", I had forgotten about setting prev in the for(...). For me, the following fixes it on MacOS (I don't have time to test on Linux right now): diff --git a/remote.c b/remote.c index 4f9f0cc..6195a58 100644 --- a/remote.c +++ b/remote.c @@ -754,6 +754,8 @@ void ref_remove_duplicates(struct ref *ref_map) prev->next = ref_map->next; free(ref_map->peer_ref); free(ref_map); + ...
Nov 13, 2:14 am 2009
Nicolas Pitre
Re: Git in next is broken
Yep, this fixes it for me on Linux too. Please resend to Junio with my ACK. Nicolas --
Nov 13, 9:54 am 2009
Eric Raible
Re: Git in next is broken
Nicolas Pitre <nico <at> fluxnic.net> writes: This is one of those example where the comment is essentially useless. Wouldn't something like "// Skip the freed item" be more useful? - Eric --
Nov 13, 1:20 pm 2009
Julian Phillips
[PATCH] remote: Fix glibc error in ref_remove_duplicates
In ref_remove_duplicates, when we encounter a duplicate and remove it from the list we need to make sure that the prev pointer stays pointing at the last entry and also skip over adding the just freed entry to the string_list. Previously fetch could crash with: *** glibc detected *** git: corrupted double-linked list: ... Also add a test to try and catch problems with duplicate removal in the future. Acked-by: Nicolas Pitre <nico@fluxnic.net> Signed-off-by: Julian Phillips ...
Nov 13, 2:25 pm 2009
Nanako Shiraishi
Re: [PATCHv3] Add branch management for releases to gitw ...
You are missing Signed-off-by: line. Here are some corrections that can be applied on top of your change. -- >8 -- Subject: [PATCH] Corrections to release management section in gitworkflows.txt The maintenance branch is supposed to be a strict subset of the master branch at all times. If you find out that this condition was violated after you pushed a release from the master branch, it is too late. Correcting that mistake will require redoing and retagging an already published ...
Nov 13, 3:19 pm 2009
Raman Gupta
Re: [PATCHv3] Add branch management for releases to gitw ...
I noticed you removed the discussion I added about the situation in which maint will *not* be a subset of master i.e. when the user has cherry-picked commits from other branches. This type of cherry-pick is described as a valid operation, though one to generally be avoided earlier in the man page. If we tell users that the occasional cherry-pick to maint is ok, then shouldn't we explain how that affects the release process? Cheers, Raman --
Nov 13, 3:56 pm 2009
Nanako Shiraishi
Re: [PATCHv3] Add branch management for releases to gitw ...
It is irrelevant that you can cherry-pick to 'maint'. You can, and Junio does, cherry-pick some commits from master to maint from time to time. But even if you have such cherry-picked commits on the maintenance branch, the result, with zero or more other maintenance commits on top, is always merged back to the master branch (you can look at "gitk origin/maint origin/master" to see yourself). So when Junio tags the release from the tip of the master branch, it is a superset of the ...
Nov 13, 4:10 pm 2009
Stephen Boyd
Re: ks/precompute-completion
I'm confused. Shouldn't your distro take care of updating the completion for you? And wouldn't update-git-completion be more suited as part of a makefile if it was needed at all? --
Nov 12, 11:40 pm 2009
Jonathan Nieder
Re: ks/precompute-completion
The problem is that I have git commands the distro did not install in my $PATH. For example, I currently have git-new-workdir in ~/bin, and once I bzr-fastexport works a little better, I will install git-bzr. Even without such commands, in many distributions the completion should not be one size fits all, since git-svn (for example) belongs to a different package. I would expect the distribution to take care of populating the initial completion list and updating it on ...
Nov 13, 12:06 am 2009
Stephen Boyd
Re: ks/precompute-completion
Ah ok. I think this proves even more that pregenerating the completion is a bad idea. With dynamic population we don't have these problems and it only takes 250ms more to load on a P3 700Mhz. Maybe we should try and speedup 'git help -a' and 'git merge -s help' instead? Perhaps options for the command/porcelain lists and available strategies formatted for script consumption? I doubt it will be as fast as compiling, but every bit helps apparently. Side Note: Running git merge -s help ...
Nov 13, 12:12 am 2009
Jonathan Nieder
[PATCH] Speed up bash completion loading
On my slow laptop (P3 600MHz), system-wide bash completions take too much time to load (> 2s), and a significant fraction of this time is spent loading git-completion.bash: $ time bash -c ". ./git-completion.bash" # hot cache, before this patch real 0m0.509s user 0m0.310s sys 0m0.180s Kirill tracked down that the most time is spent warming up merge_strategy, all_command & porcelain_command caches. Since git is not used in each and every interactive xterm, it seems best to ...
Nov 13, 1:50 am 2009
Jonathan Nieder
Re: [PATCH] Speed up bash completion loading
On my slow laptop (P3 600MHz), system-wide bash completions take too much time to load (> 2s), and a significant fraction of this time is spent loading git-completion.bash: $ time bash -c ". ./git-completion.bash" # hot cache, before this patch real 0m0.509s user 0m0.310s sys 0m0.180s Kirill noticed that most of the time is spent warming up merge_strategy, all_command & porcelain_command caches. Since git is not used in each and every interactive xterm, it seems best to load ...
Nov 13, 2:03 am 2009
Jonathan Nieder
Re: [PATCH] Speed up bash completion loading
s/__git_all_commands/\$__git_all_commands/ Yikes. Next patch I’ll let sit for a day. Good night, Jonathan --
Nov 13, 3:29 am 2009
Stephen Boyd
Re: [PATCH] Speed up bash completion loading
I was under the impression that setting variables during completion meant they were lost at the end of the completion cycle. So to be safe I put a 'sleep 5' in __git_list_porcelain_commands() and it only stalled me once :-) I see a small problem, but it can be fixed in another patch. git merge -s <TAB><TAB> the first time when you're not in a git directory will make git merge -s <TAB><TAB> after never complete correctly even in a git directory. I guess this become more serious if git ...
Nov 13, 1:43 pm 2009
Jonathan Nieder
Re: [PATCH v2] git-pull.sh --rebase: overhaul error hand ...
This sounds a little awkward to me, maybe because all the remote refs are being used to populate the remotes/<remote>/* hierarchy. I’m trying to come up with an alternative wording, but it is hard: * Merging and rebasing are about incorporating the remote history into our own, so how about something like "... no candidates for incorporating from the refs ..."? * Maybe one is using 'git pull' to update. "There are no candidates to use for an update among the refs that you ...
Nov 12, 9:07 pm 2009
Curt Sampson
Re: Bug: "git svn clone" does not honor svn.authorsfile ...
If you're running your list without munging Reply-to, congratulations to you. I'll avoid it from now on on this list. However, it's the case that for many, many lists out there, if I did not include myself in a Reply-to, the list would set the Reply-to to the list, and most MUAs would automatically exclude me from the reply. cjs -- Curt Sampson <cjs@starling-software.com> +81 90 7737 2974 Functional programming in all senses of the word: ...
Nov 13, 7:02 am 2009
Curt Sampson
Re: Bug: "git svn clone" does not honor svn.authorsfile ...
That looks plausible to me, having had a quick look at the source, but keep in mind I've already spent about 45 minutes debugging this problem and figuring out how to file a bug report. I don't really have the time at the moment to learn how to build and test new versions of git, unless someone wants to walk me through it. I expect it would take rather less time for someone in the know just to do the test. cjs -- Curt Sampson <cjs@starling-software.com> +81 90 7737 2974 ...
Nov 13, 7:06 am 2009
Johannes Schindelin
Re: BUG: git rebase -i -p silently looses commits
Hi Greg, Almost. I called it "bookmark" so that the abbreviated command does not clash with "merge". And there are possible goto targets you have never been at: - A - B - C \ / D If C is your HEAD, and you "rebase -i -p B", before cherry-picking D, you have to "goto A". So I strongly advise against trying to give all goto targets a name, just the obvious one: onto (you do not need upstream, as all the commits which At the moment, it gives you the status (which ...
Nov 13, 2:07 am 2009
Nanako Shiraishi
Re: [PATCH v2 0/2] user-manual: new "getting started" section
I didn't get myself involved in the follow-up discussion exactly The need to support both options in the same command (eg. apply) means that anybody who says "I don't like 'index' nor 'cache'; why don't we change them all to 'stage'" doesn't understand the issue. But that doesn't mean "apply --cached" vs "apply --index" is the best way to let the users specify which operation is requested. I don't think Felipe seriously wants to change them to --gogo vs --dance, but if he made a more ...
Nov 13, 2:06 pm 2009
previous daytodaynext day
November 12, 2009November 13, 2009November 14, 2009