Re: [PATCH/RFC] git-am: Make it easier to see which patch failed

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Sunday, January 18, 2009 - 8:38 pm

Jeff King <peff@peff.net> writes:


Ok, I forgot, sue me ;-).

Anyway, thanks for spotting.  I'll fix it up like this.

-- >8 --
Subject: git-am: re-fix the diag message printing

The $FIRSTLINE variable is from the user's commit and can contain
arbitrary backslash escapes that may be (mis)interpreted when given to
"echo", depending on the implementation.  Use "printf" to work around the
issue.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-am.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-am.sh b/git-am.sh
index ae2fe56..cf3d4a7 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -501,7 +501,7 @@ do
 	fi
 	if test $apply_status != 0
 	then
-		echo "Patch failed at $msgnum $FIRSTLINE"
+		printf 'Patch failed at %s %s\n' "$msgnum" "$FIRSTLINE"
 		stop_here_user_resolve $this
 	fi
 
-- 
1.6.1.245.gdd9f9

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH/RFC] git-am: Make it easier to see which patch ..., Johannes Schindelin, (Fri Jan 16, 7:14 am)
Re: [PATCH/RFC] git-am: Make it easier to see which patch ..., Johannes Schindelin, (Fri Jan 16, 9:27 am)
Re: [PATCH/RFC] git-am: Make it easier to see which patch ..., Johannes Schindelin, (Sun Jan 18, 9:17 am)
Re: [PATCH/RFC] git-am: Make it easier to see which patch ..., Johannes Schindelin, (Sun Jan 18, 10:44 am)
Re: [PATCH/RFC] git-am: Make it easier to see which patch ..., Junio C Hamano, (Sun Jan 18, 8:38 pm)