[JGIT PATCH] RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPO

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Robin Rosenberg <robin.rosenberg@...>
Cc: <git@...>, Shawn O. Pearce <sop@...>
Date: Sunday, September 7, 2008 - 5:00 pm

From: Shawn O. Pearce <sop@google.com>

The reverse sort was using the initial pending queue, not the
generator that comes before it in the workflow.  This caused
a combination of TOPO and REVERSE to return no commits.

Signed-off-by: Shawn O. Pearce <sop@google.com>
---
 .../org/spearce/jgit/revwalk/StartGenerator.java   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java b/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java
index 7ddcd3c..1b7947f 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java
@@ -144,7 +144,7 @@ RevCommit next() throws MissingObjectException,
 				&& (g.outputType() & SORT_TOPO) == 0)
 			g = new TopoSortGenerator(g);
 		if (walker.hasRevSort(RevSort.REVERSE))
-			g = new LIFORevQueue(q);
+			g = new LIFORevQueue(g);
 		if (boundary)
 			g = new BoundaryGenerator(w, g);
 
-- 
1.6.0.1.319.g9f32b

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[JGIT PATCH] RevWalk: Fix RevSort.REVERSE combined with RevS..., Shawn O. Pearce, (Sun Sep 7, 5:00 pm)