Home » Mailing list archives » git » 2008 » August » 27

Re: [PATCH] be paranoid about closed stdin/stdout/stderr

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paolo Bonzini
Subject: Re: [PATCH] be paranoid about closed stdin/stdout/stderr
Date: Wednesday, August 27, 2008 - 5:36 am

>> But it's harmless to have both.

Agree.  OTOH what about opening fd's 0/1/2 to /dev/null only in
git-shell.c, now that it's not a builtin anymore?

Maybe it does not fix Karl's use case, but it seems sensible to me.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH v2 properly indented] fix start_command() bug when ..., Paolo Bonzini, (Mon Aug 25, 6:37 am)
Re: [PATCH v2 properly indented] fix start_command() bug w ..., Karl Chen, (Mon Aug 25, 9:00 am)
Re: [PATCH v2 properly indented] fix start_command() bug w ..., Junio C Hamano, (Mon Aug 25, 5:06 pm)
Re: [PATCH v2 properly indented] fix start_command() bug w ..., Junio C Hamano, (Mon Aug 25, 11:09 pm)
Re: [PATCH v2 properly indented] fix start_command() bug w ..., Johannes Sixt, (Mon Aug 25, 11:33 pm)
Re: [PATCH v2 properly indented] fix start_command() bug w ..., Paolo Bonzini, (Mon Aug 25, 11:45 pm)
[PATCH] be paranoid about closed stdin/stdout/stderr, Paolo Bonzini, (Mon Aug 25, 11:48 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Johannes Sixt, (Mon Aug 25, 11:57 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Stephen R. van den Berg, (Tue Aug 26, 12:40 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Junio C Hamano, (Tue Aug 26, 10:38 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Paolo Bonzini, (Tue Aug 26, 11:33 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Junio C Hamano, (Tue Aug 26, 3:42 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Junio C Hamano, (Tue Aug 26, 4:04 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Stephen R. van den Berg, (Tue Aug 26, 4:10 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Nick Andrew, (Tue Aug 26, 7:04 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Karl Chen, (Tue Aug 26, 8:05 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Paolo Bonzini, (Tue Aug 26, 9:38 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Avery Pennarun, (Tue Aug 26, 10:01 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Johannes Sixt, (Tue Aug 26, 11:35 pm)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Paolo Bonzini, (Wed Aug 27, 1:20 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Stephen R. van den Berg, (Wed Aug 27, 2:04 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Stephen R. van den Berg, (Wed Aug 27, 2:18 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Paolo Bonzini, (Wed Aug 27, 5:36 am)
[PATCH v4] make git-shell paranoid about closed stdin/stdo ..., Paolo Bonzini, (Wed Aug 27, 8:20 am)
Re: [PATCH v4] make git-shell paranoid about closed stdin/ ..., Stephen R. van den Berg, (Wed Aug 27, 10:22 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Junio C Hamano, (Wed Aug 27, 10:27 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Avery Pennarun, (Wed Aug 27, 11:22 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Nick Andrew, (Thu Aug 28, 5:21 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Stephen R. van den Berg, (Thu Aug 28, 5:52 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Paolo Bonzini, (Thu Aug 28, 6:17 am)
Re: [PATCH] be paranoid about closed stdin/stdout/stderr, Stephen R. van den Berg, (Thu Aug 28, 6:58 am)