[EGIT PATCH 22/31] Set FileDialog selection appropriately in clone wizard

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <robin.rosenberg@...>, <spearce@...>
Cc: <git@...>, Marek Zawirski <marek.zawirski@...>
Date: Sunday, August 17, 2008 - 4:44 pm

Previous selection scheme was probably not correct, or at least not
portable. It hasn't worked on GTK+ SWT implementation.

New code still doesn't work on GTK+ SWT in Eclipse 3.3, but it works in
Eclipse 3.4. FileDialog for GTK+ in 3.3 was probably buggy. I've created
a bug at eclipse.org bugzilla for that (241824), but it won't be fixed
for 3.3.

Signed-off-by: Marek Zawirski <marek.zawirski@gmail.com>
---
 .../ui/internal/clone/CloneDestinationPage.java    |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java
index e1e9858..a445cf5 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java
@@ -128,9 +128,10 @@ class CloneDestinationPage extends WizardPage {
 
 				d = new FileDialog(getShell(), SWT.APPLICATION_MODAL | SWT.SAVE);
 				if (directoryText.getText().length() > 0) {
-					final File f = new File(directoryText.getText());
-					d.setFilterPath(f.getAbsoluteFile().getAbsolutePath());
-					d.setFileName(f.getName());
+					final File file = new File(directoryText.getText())
+							.getAbsoluteFile();
+					d.setFilterPath(file.getParent());
+					d.setFileName(file.getName());
 				}
 				final String r = d.open();
 				if (r != null)
-- 
1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Git-aware Issue Tracking?, Petr Baudis, (Wed Aug 20, 11:23 am)
Re: Git-aware Issue Tracking?, Imran M Yousuf, (Thu Aug 21, 4:55 am)
Re: Git-aware Issue Tracking?, Mike Dalessio, (Wed Aug 20, 4:22 pm)
Re: Git-aware Issue Tracking?, Jakub Narebski, (Wed Aug 20, 2:52 pm)
Re: Git-aware Issue Tracking?, Pierre Habouzit, (Thu Aug 21, 4:30 am)
Re: Git-aware Issue Tracking?, Jakub Narebski, (Thu Aug 21, 5:23 am)
Re: Git-aware Issue Tracking?, Shawn O. Pearce, (Wed Aug 20, 12:44 pm)
Re: Git-aware Issue Tracking?, Martin Langhoff, (Thu Aug 21, 4:47 am)
Re: Git-aware Issue Tracking?, Robin Rosenberg, (Wed Aug 20, 4:25 pm)
[EGIT PATCH 6/6] Fix RefSpecPage formatting, Marek Zawirski, (Tue Aug 19, 10:57 pm)
[EGIT PATCH 10/31] Improve javadoc of Transport push(), Marek Zawirski, (Sun Aug 17, 4:43 pm)
[EGIT PATCH 17/31] Fix typo in uitext.properties message, Marek Zawirski, (Sun Aug 17, 4:43 pm)
[EGIT PATCH 22/31] Set FileDialog selection appropriately in..., Marek Zawirski, (Sun Aug 17, 4:44 pm)
[EGIT PATCH 27/31] Add few EPL Eclipse icons, Marek Zawirski, (Sun Aug 17, 4:44 pm)
[EGIT PATCH 28/31] Checkbox images/screenshots, Marek Zawirski, (Sun Aug 17, 4:44 pm)
Re: [EGIT PATCH 28/31] Checkbox images/screenshots, Robin Rosenberg, (Tue Aug 19, 2:24 pm)
[EGIT PATCH 30/31] Add PushOperation to plugin, Marek Zawirski, (Sun Aug 17, 4:44 pm)
[EGIT PATCH 31/31] Push GUI, Marek Zawirski, (Sun Aug 17, 4:44 pm)